Check the return value of the dom_externalize.

[oshogbo]

Summary

The error value of the dom_externalize is fetched but never used
in those two cases.

[kib]

sys/kern/uipc_socket.c

1896

Don't we leak cm ?

May be not, at least not in unix domain socket case, but is it guaranteed by the dom_externalize() interface ?

2523

Same question.

[oshogbo]

sys/kern/uipc_socket.c

1896

In case of the unix domain socket it would be a double free on error, and we don't have really method to check or return info if the cm was freed or not that with this interface.
TBH I don't see any other consumer of dom_externalize, I guess we should document somewhere (in struct comment?) that the cm *must be* consumed.

[markj]

sys/kern/uipc_socket.c

1896

Note that we set cm->m_next = NULL above. This means that the rest of the control mbuf chain is not being freed in case of an error.