Page MenuHomeFreeBSD

Increase EFI_STAGING_SIZE to 150MB
AbandonedPublic

Authored by bcran on Jun 26 2019, 8:52 PM.

Details

Summary

To avoid failures when the large 18MB nvidia.ko module is being loaded,
increase EFI_STAGING_SIZE from 64MB to 150MB for x64 systems. Leave others at 64MB.
This also allows space for a kernel built with ubsan.

Test Plan

I created a VM and copied over my /boot/loader.conf from my desktop system, along with /boot/modules/nvidia.ko and /boot/modules/nvidia-modeset.ko.

Without this change, I saw elf64_obj_load errors, and either nvidia.ko would fail to load, or it would load and other modules wouldn't load. After applying this patch, all modules were successfully loaded and boot proceeded normally.

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 25073
Build 23780: arc lint + arc unit

Event Timeline

bcran created this revision.Jun 26 2019, 8:52 PM
bcran edited the summary of this revision. (Show Details)Jun 26 2019, 8:55 PM
bcran edited the test plan for this revision. (Show Details)
bcran updated this revision to Diff 59083.Jun 26 2019, 9:14 PM
  • Only bump EFI_STAGING_SIZE for x64
bcran edited the summary of this revision. (Show Details)Jun 26 2019, 9:15 PM
bcran abandoned this revision.Jun 27 2019, 10:07 PM

I committed a temporary fix to increase the size to 100MB on x64 in r349471.