Differential D20776

Increase EFI_STAGING_SIZE to 150MB
AbandonedPublic
Actions

Authored by bcran on Jun 26 2019, 8:52 PM.

Tags

None

Referenced Files

	F81592804: D20776.diff
	Thu, Apr 18, 3:50 PM

	Unknown Object (File)
	Wed, Apr 17, 6:16 AM

	Unknown Object (File)
	Feb 11 2024, 3:19 AM

	Unknown Object (File)
	Dec 23 2023, 3:24 AM

	Unknown Object (File)
	Dec 8 2023, 2:23 AM

	Unknown Object (File)
	Sep 19 2023, 1:14 PM

	Unknown Object (File)
	Aug 31 2023, 8:52 PM

	Unknown Object (File)
	Jul 10 2023, 4:17 PM

View All 16 Files

Subscribers

None

Details

Reviewers

imp
tsoome
kevans
manu

Summary

To avoid failures when the large 18MB nvidia.ko module is being loaded,
increase EFI_STAGING_SIZE from 64MB to 150MB for x64 systems. Leave others at 64MB.
This also allows space for a kernel built with ubsan.

Test Plan

I created a VM and copied over my /boot/loader.conf from my desktop system, along with /boot/modules/nvidia.ko and /boot/modules/nvidia-modeset.ko.

Without this change, I saw elf64_obj_load errors, and either nvidia.ko would fail to load, or it would load and other modules wouldn't load. After applying this patch, all modules were successfully loaded and boot proceeded normally.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25073
Build 23780: arc lint + arc unit

Event Timeline

bcran created this revision.Jun 26 2019, 8:52 PM

Harbormaster completed remote builds in B25072: Diff 59081.Jun 26 2019, 8:52 PM

bcran edited the summary of this revision. (Show Details)Jun 26 2019, 8:55 PM

bcran edited the test plan for this revision. (Show Details)

Only bump EFI_STAGING_SIZE for x64

Harbormaster completed remote builds in B25073: Diff 59083.Jun 26 2019, 9:14 PM

bcran edited the summary of this revision. (Show Details)Jun 26 2019, 9:15 PM

I committed a temporary fix to increase the size to 100MB on x64 in r349471.

Revision Contents
Changeset List

Path

Size

stand/

efi/

loader/

6 lines

Diff 59083

stand/efi/loader/copy.c

Loading...