This treats
MFH: 2019Q2 (any text)
as a signal not to send the MFH request email.
Differential D20698
Make it possible not to send MFH emails adamw on Jun 19 2019, 12:25 PM. Authored by Tags None Referenced Files
Details
This treats MFH: 2019Q2 (any text) as a signal not to send the MFH request email.
Diff Detail
Event TimelineComment Actions I don't know about this, I think it is better to send an email that is ignored than silently doing things. Comment Actions I think ultimately what happens on quarterly branch is still being covered by commit mail? This only affects MFH approval email, which seems to be redundant if it's a hat commit and the intention was not to ask an approval in the first place. Comment Actions Then if the MFH line contains anything else than a branch name, say:
There is no need to send an email because it will already have gotten committed. Maybe it should echo the fact that no MFH email is being sent. (So need two tests.) Comment Actions That's what the above patch does.
That's a great idea. Instant feedback would help alleviate the behaving-silently thing. Comment Actions That's what it does only when you write "with hat". What I mean is that if you add a comment on the MFH line, whatever the comment is, an email should not be sent.
Comment Actions I think we can safely abandon this? MFH mails are not sent anymore anyway and ports migrated to git. |