Page MenuHomeFreeBSD

Remove unconditional _GNU_SOURCE define from devel/sdl12
ClosedPublic

Authored by madpilot on Mar 14 2015, 3:15 PM.

Details

Reviewers
mva
Summary

SDL 1.2 unconditionally defines _GNU_SOURCE via it's sdl-config script.

The new version of port games/0ad(which I'm testing) fails to build with such a a define. It's also anyway wrong to force such a define on anything depending on sdl 1.2.

The attached patch I'm proposing for review is taken from upstream:

http://hg.libsdl.org/SDL/rev/7b87c1773b3e

and removes such define.

I was pointed to it by one of the 0ad developers.

Test Plan

I think an exprun is needed before committing this patch.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

madpilot retitled this revision from to Remove unconditional _GNU_SOURCE define from develsdl12.
madpilot updated this object.
madpilot edited the test plan for this revision. (Show Details)
madpilot changed the visibility from "Public (No Login Required)" to "madpilot (Guido Falsi)".
madpilot changed the edit policy from "All Users" to "madpilot (Guido Falsi)".
madpilot retitled this revision from Remove unconditional _GNU_SOURCE define from develsdl12 to Remove unconditional _GNU_SOURCE define from devel/sdl12.
madpilot updated this object.
madpilot changed the visibility from "madpilot (Guido Falsi)" to "Public (No Login Required)".Mar 14 2015, 4:44 PM
madpilot changed the edit policy from "madpilot (Guido Falsi)" to "All Users".
madpilot added a reviewer: mva.
mva edited edge metadata.

Excellent, thanks. @madpilot: accepted.

This revision is now accepted and ready to land.Mar 21 2015, 5:56 PM