Page MenuHomeFreeBSD

MFC r324736:
AbandonedPublic

Authored by ngie on Apr 21 2019, 8:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 4:43 AM
Unknown Object (File)
May 8 2023, 11:58 PM
Unknown Object (File)
Jan 12 2023, 10:35 PM
Unknown Object (File)
Dec 9 2022, 10:16 PM
Unknown Object (File)
Nov 28 2022, 6:14 PM
Subscribers

Details

Reviewers
mjg
Summary

r324736 (by mjg):

sysctl: only take mem lock if oldlen is > 4 * PAGE_SIZE

The previous limit of just one page is hit by ps.

The entire mechanism should be reworked, if not whacked. It seems the intent
is to reduce kernel dos-ability - some handlers wire the amount of memory
passed here. Handlers should probably stop wiring in the first place or in
the worst case indicate they are doing so so that the check is done only if
necessary. It should also probably be a counter, not a lock.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23805
Build 22749: arc lint + arc unit

Event Timeline

That's not what I wanted to do >_>...

Fix accidental diff update in last revision

This revision is now accepted and ready to land.Apr 23 2019, 5:12 PM

So this is not in stable/11 and it probably is not important to get there. It is in 12.0 Can this be closed?

In D19997#468014, @mjg wrote:

So this is not in stable/11 and it probably is not important to get there. It is in 12.0 Can this be closed?

Yes. I don't remember the exact context as to why I was pushing for this change, but it's not critical getting this into 11.x.

Abandoning the revision.