Page MenuHomeFreeBSD
Differential D19764

Fix if_(m)addr_rlock() on stable/12.
ClosedPublic
Actions

Authored by markj on Mar 30 2019, 5:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 14, 6:29 PM
Unknown Object (File)
Sun, Apr 14, 6:06 PM
Unknown Object (File)
Sun, Apr 14, 5:50 PM
Unknown Object (File)
Jan 28 2024, 8:07 PM
Unknown Object (File)
Dec 21 2023, 12:24 AM
Unknown Object (File)
Dec 20 2023, 6:11 AM
Unknown Object (File)
Nov 9 2023, 9:30 PM
Unknown Object (File)
Nov 8 2023, 2:39 PM
View All 26 Files
Subscribers
ae
emaste
imp

Details

Reviewers
glebius
• hselasky
Commits
rS345764: Fix if_(m)addr_rlock().
Summary

This is an alternative to r340413 that does not break the KBI. We have
users hitting the bug on 12.0, and the patch D17996 solves the problem.

Test Plan

One stf(4) user was hitting memory corruption panics that have gone
away with this patch applied to stable/12.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Mar 30 2019, 5:48 PM
Herald added a subscriber: ae. · View Herald TranscriptMar 30 2019, 5:48 PM
Harbormaster completed remote builds in B23401: Diff 55624.Mar 30 2019, 5:48 PM
markj edited the test plan for this revision. (Show Details)Mar 30 2019, 5:48 PM
markj added reviewers: glebius, • hselasky.
markj added a subscriber: emaste.
• hselasky accepted this revision.Mar 30 2019, 6:57 PM

The patch technically looks good to me. Is this change for MFC only?

This revision is now accepted and ready to land.Mar 30 2019, 6:57 PM
markj added a comment.Mar 30 2019, 8:00 PM
In D19764#423635, @hselasky wrote:

The patch technically looks good to me. Is this change for MFC only?

My plan is to commit directly to stable/12 and request an EN for 12.0.

markj added inline comments.Apr 1 2019, 1:55 PM
sys/net/if_var.h
385 ↗(On Diff #55624)

We have to replace these with padding to preserve the KBI.

Closed by commit rS345764: Fix if_(m)addr_rlock(). (authored by markj). · Explain WhyApr 1 2019, 2:19 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptApr 1 2019, 2:19 PM
ae added a comment.EditedApr 1 2019, 4:07 PM

Mark, do you suppose that this can fix some another strange panics that appeared after epochification?

markj added a comment.Apr 1 2019, 4:30 PM
In D19764#424043, @ae wrote:

Mark, do you suppose that this can fix some another strange panics that appeared after epochification?

It's hard to say without more info. The two cases I saw were indeed "strange": one panic in kevent, and one in the pfil hooks. Note that the problem applies only to stable/12, the bug has been fixed in head for a few months.

markj added a comment.Apr 1 2019, 5:19 PM
In D19764#424054, @markj wrote:
In D19764#424043, @ae wrote:

Mark, do you suppose that this can fix some another strange panics that appeared after epochification?

It's hard to say without more info. The two cases I saw were indeed "strange": one panic in kevent, and one in the pfil hooks. Note that the problem applies only to stable/12, the bug has been fixed in head for a few months.

Note, this was without INVARIANTS. With INVARIANTS enabled we saw an assertion failure in the epoch code.

Revision Contents
Changeset List

PathSize
stable/
12/
sys/
net/
62 lines
3 lines

Diff 55671

View Options

stable/12/sys/net/if.c

Loading...
View Options

stable/12/sys/net/if_var.h

Loading...