Page MenuHomeFreeBSD

Do not install NIS related headers when MK_NIS == "no"
ClosedPublic

Authored by garga on Mar 25 2019, 1:50 PM.
Tags
None
Referenced Files
F81950330: D19701.diff
Tue, Apr 23, 3:58 PM
Unknown Object (File)
Sat, Apr 20, 2:45 PM
Unknown Object (File)
Wed, Apr 17, 2:36 AM
Unknown Object (File)
Fri, Apr 5, 2:18 AM
Unknown Object (File)
Feb 21 2024, 9:10 PM
Unknown Object (File)
Dec 25 2023, 3:04 AM
Unknown Object (File)
Dec 23 2023, 3:13 AM
Unknown Object (File)
Dec 8 2023, 4:59 AM
Subscribers

Details

Reviewers
ngie
loos
Summary

include/rpcsvc headers are always being installed. Isolate NIS related
headers and don't install them when MK_NIS is defined.

Add these files to OptionalObsoleteFiles.inc so they are removed by
delete-old

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196197

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23286
Build 22318: arc lint + arc unit

Event Timeline

The change by itself is good, but please be sure to run this through an exp- run and make sure to run “make buildworld” on a system without these headers and MK_NIS==no.

This revision is now accepted and ready to land.Mar 25 2019, 3:20 PM
In D19701#422022, @ngie wrote:

The change by itself is good, but please be sure to run this through an exp- run and make sure to run “make buildworld” on a system without these headers and MK_NIS==no.

buildworld on a system without those headers didn't work.

/usr/src/lib/libc/rpc/auth_des.c:54:10: fatal error: 'rpcsvc/nis.h' file not found
#include <rpcsvc/nis.h>
         ^~~~~~~~~~~~~~
1 error generated.

I'll need some time to take a look at it. The way it is today is breaking ports like samba when WITHOUT_NIS=yes is set. samba considers NIS is installed because it finds headers