kde.mk, qt.mk: Prefix component variables to avoid clashes.
ClosedPublic
Actions

Authored by rakuco on Mar 18 2019, 9:57 PM.

Details

Reviewers

Group Reviewers

kde
O5: Ports Framework
portmgr

Commits

rP496296: kde.mk, qt.mk: Prefix component variables to avoid clashes.

Summary

rP496074 was necessary because both kde.mk and qt.mk were setting wayland_LIB and wayland_PORT, and qt.mk overrode the version in kde.mk.

Follow what we do in pyqt.mk and prefix the component variables to avoid future clashes.

Test Plan

Qt and KDE ports still built correctly.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rakuco created this revision.Mar 18 2019, 9:57 PM

Owners added a reviewer: O5: Ports Framework.Mar 18 2019, 9:57 PM

Herald added a reviewer: portmgr. · View Herald TranscriptMar 18 2019, 9:57 PM

Herald added a subscriber: mat. · View Herald Transcript

Harbormaster completed remote builds in B23170: Diff 55215.Mar 18 2019, 9:57 PM

Thank you :)

This revision was not accepted when it landed; it landed in state Needs Review.Mar 19 2019, 10:34 PM

Closed by commit rP496296: kde.mk, qt.mk: Prefix component variables to avoid clashes. (authored by rakuco). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Packages

head/

Mk/

Uses/

750 lines

300 lines

Diff 55254

View Options

head/Mk/Uses/kde.mk