security/libressl-devel: fix build on arm
AbandonedPublic
Actions

Authored by vishwin on Feb 21 2019, 6:18 PM.

Details

Reviewers

brnrd

Summary

arm has assembly files, and upstream forgot to add the header to the build.

Obtained from: OpenBSD
https://github.com/libressl-portable/portable/commit/7d5b905723156d5ae34670e785c78f78b62194c0

Test Plan

testport: OK

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 22647
Build 21753: arc lint + arc unit

Event Timeline

vishwin created this revision.Feb 21 2019, 6:18 PM

Herald added a subscriber: andrew. · View Herald TranscriptFeb 21 2019, 6:18 PM

Harbormaster completed remote builds in B22647: Diff 54193.Feb 21 2019, 6:18 PM

vishwin set the repository for this revision to rP FreeBSD ports repository.Feb 21 2019, 6:18 PM

linimon added a subscriber: linimon.Feb 22 2019, 5:27 AM

poudriere testport builds fine on 11.2/12.0 amd64 and i386.

Does it currently build on arm? That means we need to bump PORTREVISION too...

Passing testport means it built successfully. And testport in this case was on arm. No problems with runtime or consumers linking with it either.

In D19286#413291, @ml_vishwin.info wrote:

Passing testport means it built successfully. And testport in this case was on arm. No problems with runtime or consumers linking with it either.

If the port as it currently is _doesn't_ build I don't have to bump the PORTREVISION.
If the current port builds/packages I need to bump PORTREVISION so all ARM users get the assembly bits.

In D19286#413694, @brnrd wrote:

If the port as it currently is _doesn't_ build I don't have to bump the PORTREVISION.
If the current port builds/packages I need to bump PORTREVISION so all ARM users get the assembly bits.

Without this patch, the port does not build on arm, so no PORTREVISION bump necessary.

This is abandoned as LibreSSL 2.9.1 released.