bhyve(8) pci_xhci.c elliminate possible double free of uopt

[rgrimes]

Summary

In r340044 an attempt to quiet coverity warning cid 1357336 was incorrectly implemented leading to a possible double free.

It is possible for both the conditional free, and the unconditional free added in r340044 to be done, fix that by initializing uopt to NULL, removing the conditional free, and only using the unconditional free at the end.

Brought to my attention by Patrick Mooney of Joyent/illumos

Test Plan

Visial code inspection, and compile tested.

[pmooney_pfmooney.com]

This is the fix we're applying to SmartOS bhyve, after syncing from upstream.

[jhb]

usr.sbin/bhyve/pci_xhci.c

2629 ↗

(On Diff #53936)

style nit would be to initialize the value on a separate line here rather than in the declaration.

[rgrimes]

Move initialization of uopt to after declares addressing jhb style(9) issue

[rgrimes]

Address jhb style 9 issues

usr.sbin/bhyve/pci_xhci.c

2629 ↗

(On Diff #53936)

You are correct, I applied my minimal lines of diff and no style correction. I should of just added a line after the declares to initialize it, as that achives the same result.