Page MenuHomeFreeBSD

x11/polybar: update to version 3.3.0
ClosedPublic

Authored by rigoletto on Dec 24 2018, 12:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 9, 2:16 PM
Unknown Object (File)
Mar 16 2024, 1:24 PM
Unknown Object (File)
Jan 7 2024, 11:38 PM
Unknown Object (File)
Nov 18 2023, 11:07 PM
Unknown Object (File)
Nov 18 2023, 9:21 PM
Unknown Object (File)
Nov 18 2023, 9:15 PM
Unknown Object (File)
Nov 18 2023, 8:24 PM
Unknown Object (File)
Nov 18 2023, 8:23 PM
Subscribers
None

Details

Reviewers
mat
tcberner
Summary
  • update to version 3.3.0
  • completely disable network early support since it needs libnl
  • add PULSEAUDIO option.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 21719
Build 21003: arc lint + arc unit

Event Timeline

x11/polybar/Makefile
27

^ that isn't the tag for 3.3.0, I think: https://github.com/jaagr/polybar/releases/tag/3.3.0

this one is: 3.2.0-73-gbc9eddf

46

^ you mean PULSAUDIO_DESC, and that is already defined in bsd.options.desc.mk :) so you can just drop it.

69

^ are you sure that i3 is only needed during build time?

78

^ this should come earlier.

x11/polybar/Makefile
46

Side note, <opt>_DESC= <opt> support is really really bad. Of course enabling opt makes opt supported. What is important is to describe what it does for the port, say, for example, here, maybe "Enable pulseaudio audio output", or whatever pulseaudio does.

rigoletto marked 5 inline comments as done.
  • remove GH_TAGNAME
  • remove PULSEAUDIO description
  • remove PULSEAUDIO_BUILD_DEPENDS
  • move CMAKE_OFF to earlier
  • remove the unused EXAMPLES OPTION
  • rename the CURL OPTION to GITHUB
  • rewrite some OPTIONS descriptions
  • add CURSOR and XKEYBORAD OPTIONS
This revision is now accepted and ready to land.Dec 24 2018, 1:57 PM
This revision now requires review to proceed.Dec 24 2018, 2:11 PM
  • improve XKEYBOARD description
This revision is now accepted and ready to land.Dec 24 2018, 3:18 PM

Sorry. I forgot to add the revision number (D18642) to Differential Revision in the commit message. Thanks!

x11/polybar/Makefile
27

Forgot to remove this one.

69

This actually was a copy/paste mistake.