[new port] deskutils/gnome-shell-extension-gsconnect: KDE Connect implementation for GNOME
Needs ReviewPublic
Actions

Authored by daniel_shafer.cc on Dec 23 2018, 9:34 AM.

Details

Reviewers

Summary

This port is for the Gnome Shell extension gsconnect. After working with the developer
closely, we were able to port this to FreeBSD. Originally didn't work due to an issue
in core.js, which is patched. (Fix will be released next update).

Also note, this is dependant on the new nautilus-python port: https://reviews.freebsd.org/D18415

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 21782
Build 21056: arc lint + arc unit

Event Timeline

daniel_shafer.cc created this revision.Dec 23 2018, 9:34 AM

Herald added a subscriber: mat. · View Herald TranscriptDec 23 2018, 9:34 AM

Harbormaster completed remote builds in B21692: Diff 52256.Dec 23 2018, 9:34 AM

daniel_shafer.cc edited the summary of this revision. (Show Details)Dec 23 2018, 9:35 AM

mat added inline comments.Dec 24 2018, 11:41 AM

deskutils/gnome-shell-extension-gsconnect/Makefile
39–58	All these are badly ordered. See Chapter 15. Order of Variables in Port Makefiles.

Reordered Makefile, moved gsound and nautilus depends to USE_GNOME nautilus3 and gsound.
I'm unsure how else I could reorder this port, so if anyone wants to provide any suggestions
I am open. I've tried reading the Makefile order page in porters manual, so hopefully its
improved.

Harbormaster completed remote builds in B21722: Diff 52300.Dec 24 2018, 9:31 PM

My previous updated diff was missing my updated pkg-descr, fixed that

Harbormaster completed remote builds in B21723: Diff 52301.Dec 24 2018, 9:34 PM

mat added inline comments.Dec 25 2018, 12:34 PM

deskutils/gnome-shell-extension-gsconnect/Makefile
48–56	these are framework variables and should go before options.
deskutils/gnome-shell-extension-gsconnect/pkg-plist
71	empty line, remove.

Updated to v19, reordered based on mat's suggestions. Updated pkg-plist for new version.
Updated pkg-message to include a release note that might be required by some users.
Regenerated distfile

Harbormaster completed remote builds in B21782: Diff 52425.Dec 30 2018, 11:36 AM