Page MenuHomeFreeBSD

Revert r336326.
ClosedPublic

Authored by markj on Dec 17 2018, 6:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 28, 8:46 PM
Unknown Object (File)
Mar 10 2024, 12:24 PM
Unknown Object (File)
Jan 18 2024, 9:05 AM
Unknown Object (File)
Dec 20 2023, 8:21 AM
Unknown Object (File)
Nov 8 2023, 7:07 PM
Unknown Object (File)
Oct 13 2023, 3:21 AM
Unknown Object (File)
Aug 31 2023, 3:28 PM
Unknown Object (File)
Aug 24 2023, 9:36 PM
Subscribers
None

Details

Summary

On my Dell Latitude, the suspend/resume issue caused by ig4 appears to
be resolved by r342170. In particular, while debugging the issue I
found that ig4iic_pci0 and vgapci0 share an interrupt, and ig4iic_intr() was
being called after the device entered D3, so the read of IG4_REG_I2C_STA
returned 0xffffffff and we would enter an infinite loop as a result.

Test Plan

Suspend/resume on my laptop now works with ig4.ko. I happened to be
debugging the issue at the same time that r342170 was committed, so
based on the symptoms I'm fairly confident that r342170 addressed the
root cause.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21619
Build 20914: arc lint + arc unit

Event Timeline

markj added reviewers: imp, gonzo, grembo.
This revision is now accepted and ready to land.Dec 17 2018, 6:26 PM
This revision was automatically updated to reflect the committed changes.