net/zerotier: wait for ONLINE status before booting

[mat]

Does this pass rclint?

[dch]

The underlying issue I'm trying to fix is to get the interfaces up and have an
IP available *before* we allow pf|ipfw to run. I'm pretty sure that this doesn't
actually do what I want at present, but I've not figured out a good way of
debugging things that early in the boot phase.

[dch]

• updated diff removes hardcoded paths, cleaned for rclint
• confirmed it really does work when zerotier is newly installed and after joining a secure network
• found it blocks the boot completely if the environment uses static IP rather than DHCP
• see https://github.com/zerotier/ZeroTierOne/issues/900 for community feedback

[mat]

net/zerotier/files/zerotier.in

38 ↗

(On Diff #52239)

This is probably wrong, and should be PREFIX.

44 ↗

(On Diff #52239)

PREFIX here too, no?

[dch]

merge in DHCP handling and fix nits

[dch]

handle wait loop vars correctly

[dch]

remove local.conf we do not want to provide one but we refer people
to online docs in pkg-message instead.

[dch]

seems we have doubled up, D19229 is the place to B....SD.

[dch]

facepalm nope need this, wrong browser tab :(

[jrm]

poudriere testport 11.2/12.0 i386/amd64 pass. rclint reports one error about clobbering blank values for non-mandatory variables : ${zerotier_wait_for_net:=NO}, but this seems reasonable.