Temporarily skip flip-flop test cases
ClosedPublic
Actions

Authored by lwhsu on Nov 27 2018, 11:01 PM.

Details

Reviewers

emaste
markj

Commits

rS341623: Temporarily skip flakey test cases

Summary

Temporarily skip flip-flop test cases

PR: 233586, 233587, 233588

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21251
Build 20593: arc lint + arc unit

Event Timeline

lwhsu created this revision.Nov 27 2018, 11:01 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 27 2018, 11:01 PM

Harbormaster completed remote builds in B21232: Diff 51236.Nov 27 2018, 11:02 PM

markj added inline comments.Nov 28 2018, 1:38 AM

tests/sys/kqueue/libkqueue/Makefile
8 ↗	(On Diff #51236)	Rather than disabling all of them, I'd prefer to just disable test_evfilt_proc().

Only disable test_evfilt_proc()

lwhsu marked 2 inline comments as done.Nov 28 2018, 10:35 PM

lwhsu added inline comments.

tests/sys/kqueue/libkqueue/Makefile
8 ↗	(On Diff #51236)	Yes this makes more sense and fortunately it's easy to do so. Thanks!

Harbormaster completed remote builds in B21251: Diff 51304.Nov 28 2018, 10:37 PM

Approved

This revision was not accepted when it landed; it landed in state Needs Review.Dec 6 2018, 9:22 AM

Closed by commit rS341623: Temporarily skip flakey test cases (authored by lwhsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

lwhsu marked an inline comment as done.

Revision Contents
Changeset List

Path

Size

tests/

sys/

kqueue/

libkqueue/

kqueue_test.sh

3 lines

usr.bin/

procstat/

tests/

procstat_test.sh

4 lines

Diff 51304

View Options

tests/sys/kqueue/libkqueue/kqueue_test.sh