Page MenuHomeFreeBSD

Fix TCP module unloading code to work with epoch(9) changes
AcceptedPublic

Authored by jtl on Oct 16 2018, 4:39 PM.

Details

Reviewers
rrs
lstewart
mmacy
glebius
Group Reviewers
transport
Summary

The TCP stack and CC algorithm removal code assumed that it could use the INP_INFO_WLOCK to prevent races with TCP connection creation and destruction. However, that is no longer the case now that the INP_INFO_RLOCK is really an epoch(9) reach section.

Modify the destructors to wait for all epoch sections to complete prior to checking which connections use the object which is being unloaded.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 20249
Build 19726: arc lint + arc unit

Event Timeline

jtl created this revision.Oct 16 2018, 4:39 PM
jtl updated this revision to Diff 49231.Oct 16 2018, 4:48 PM

Fix stupid syntax error.

rrs accepted this revision.Oct 16 2018, 6:10 PM
This revision is now accepted and ready to land.Oct 16 2018, 6:10 PM