Add new counter descriptions to AMD 0x17

[debdrup]

Did you think about getting some reviewers attached for this, as well as fixing the various errors?
The reason I ask is because it doesn't seem like a bad change, but if it's going to go into the tree there's typically some sort of review process.

[mmacy]

lib/libpmc/libpmc_pmu_util.c

159 ↗

(On Diff #48709)

Style notice the tabs above

429 ↗

(On Diff #48709)

Style.

sys/dev/hwpmc/hwpmc_amd.c

590 ↗

(On Diff #48709)

Notice how nothing else returns -1 like this.

sys/dev/hwpmc/hwpmc_amd.h

90 ↗

(On Diff #48709)

Style

[somalapuram_gmail.com]

<<hwpmc> Add library and kernel support for AMD Family 17h new counters L3 Cache and Data Fabric

[somalapuram_gmail.com]

updated the code

[somalapuram_gmail.com]

updated the code

[somalapuram_gmail.com]

Can you please review this.

[mmacy]

Do you need this in for the 12 release? I can do that, it just means some more hoops for me jump through.

[somalapuram_gmail.com]

In D17401#373648, @mmacy wrote:

Do you need this in for the 12 release? I can do that, it just means some more hoops for me jump through.

Yes we need this for 12.0 release

[somalapuram_gmail.com]

In D17401#373648, @mmacy wrote:

Do you need this in for the 12 release? I can do that, it just means some more hoops for me jump through.

I am unable to commit (svn commit). (https://wiki.freebsd.org/Phabricator)

Do I have to commit or it will be automatically do ?? do I miss any steps ??

svn-commit.tmp: 36 lines, 1596 characters.
svn: E170001: Commit failed (details follow):
svn: E170001: Authorization failed
svn: E170001: Your commit message was left in a temporary file:
svn: E170001: '/usr/home/amar/freebsd_svn/freebsd_head/svn-commit.tmp'

[mmacy]

In D17401#373706, @somalapuram_gmail.com wrote:

In D17401#373648, @mmacy wrote:

Do you need this in for the 12 release? I can do that, it just means some more hoops for me jump through.

I am unable to commit (svn commit). (https://wiki.freebsd.org/Phabricator)

Do I have to commit or it will be automatically do ?? do I miss any steps ??

svn-commit.tmp: 36 lines, 1596 characters.
svn: E170001: Commit failed (details follow):
svn: E170001: Authorization failed
svn: E170001: Your commit message was left in a temporary file:
svn: E170001: '/usr/home/amar/freebsd_svn/freebsd_head/svn-commit.tmp'

Someone with a commit bit needs to do it

[somalapuram_gmail.com]

In D17401#373713, @mmacy wrote:

In D17401#373706, @somalapuram_gmail.com wrote:

In D17401#373648, @mmacy wrote:

Do you need this in for the 12 release? I can do that, it just means some more hoops for me jump through.

I am unable to commit (svn commit). (https://wiki.freebsd.org/Phabricator)

Do I have to commit or it will be automatically do ?? do I miss any steps ??

svn-commit.tmp: 36 lines, 1596 characters.
svn: E170001: Commit failed (details follow):
svn: E170001: Authorization failed
svn: E170001: Your commit message was left in a temporary file:
svn: E170001: '/usr/home/amar/freebsd_svn/freebsd_head/svn-commit.tmp'

Someone with a commit bit needs to do it

Hi Macy can you help me to commit this changes..

[mmacy]

In D17401#379234, @somalapuram_gmail.com wrote:

In D17401#373713, @mmacy wrote:

In D17401#373706, @somalapuram_gmail.com wrote:

In D17401#373648, @mmacy wrote:

Do you need this in for the 12 release? I can do that, it just means some more hoops for me jump through.

I am unable to commit (svn commit). (https://wiki.freebsd.org/Phabricator)

Do I have to commit or it will be automatically do ?? do I miss any steps ??

svn-commit.tmp: 36 lines, 1596 characters.
svn: E170001: Commit failed (details follow):
svn: E170001: Authorization failed
svn: E170001: Your commit message was left in a temporary file:
svn: E170001: '/usr/home/amar/freebsd_svn/freebsd_head/svn-commit.tmp'

Someone with a commit bit needs to do it

Hi Macy can you help me to commit this changes..

Sorry - I didn’t see this in my queue. Will do today.