Page MenuHomeFreeBSD
Differential D17111

Address jtl's review feedback from D17065.
AbandonedPublic
Actions

Authored by markj on Sep 10 2018, 6:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 23 2023, 2:48 AM
Unknown Object (File)
Nov 29 2023, 6:58 AM
Unknown Object (File)
Nov 24 2023, 1:59 AM
Unknown Object (File)
Nov 23 2023, 5:16 PM
Unknown Object (File)
Sep 14 2023, 7:21 AM
Unknown Object (File)
Aug 26 2023, 5:25 AM
Unknown Object (File)
Jun 26 2023, 12:50 PM
Unknown Object (File)
Jun 26 2023, 10:21 AM
View All 11 Files
Subscribers
eugen_grosbein.net
melifaro

Details

Reviewers
jtl
Group Reviewers
network

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19504
Build 19097: arc lint + arc unit

Event Timeline

markj created this revision.Sep 10 2018, 6:19 PM
Harbormaster completed remote builds in B19504: Diff 47887.Sep 10 2018, 6:19 PM
markj added reviewers: jtl, network.Sep 10 2018, 6:20 PM
eugen_grosbein.net added a subscriber: eugen_grosbein.net.Sep 10 2018, 7:46 PM

Why is it acceptable to break KBI here adding new member to struct inpcblbgroup not to its end?

markj added a comment.Sep 10 2018, 7:48 PM
In D17111#364798, @eugen_grosbein.net wrote:

Why is it acceptable to break KBI here adding new member to struct inpcblbgroup not to its end?

This structure is not part of the KBI AFAIK. If it was, adding a member to its end would also break the KBI.

markj abandoned this revision.Apr 20 2021, 1:50 PM
Herald added a subscriber: melifaro. · View Herald TranscriptApr 20 2021, 1:50 PM

Revision Contents
Changeset List

PathSize
sys/
netinet/
1 line
5 lines

Diff 47887

View Options

sys/netinet/in_pcb.h

Loading...
View Options

sys/netinet/in_pcb.c

Loading...