devel/gnu-efi: Update to 3.0.8; Remove only for amd64
AbandonedPublic
Actions

Authored by ndowens_yahoo.com on Sep 8 2018, 4:46 AM.

Details

Test Plan

Need testers to see if this will actually run on the other platforms
Built fine on 10/11 arm64,amd64,i386 12:amd64,i386

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 19462
Build 19055: arc lint + arc unit

Supposedly it will also run on mips64 but I currently dont have a mips64 jail to build on; which I guess I will create now

mat added inline comments.Sep 8 2018, 7:05 AM

devel/gnu-efi/Makefile
13	Would probably be best to set: BROKEN_mips= blah with an actual message.
19–20	Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.
27–45	Please do not mix pkg-plist and PLIST_FILES.
51–55	Have you tested this? YOu cannot set any OPTIONS variables after an include.

ndowens_yahoo.com added inline comments.

devel/gnu-efi/Makefile
27–45	Can you tell me how to not mix them? As the files change based on ARCH. Only other way is to do away with the pkg-plist and put all of it in Makefile, which is more than 6(portlint warning IIRC). It'd be possible to have all in pkg-plist but aarch64 doesn't have include/efi/ia32/pe.h and amd64's efi.lds filename is a little diff than i386's