Page MenuHomeFreeBSD

Turn drm2 back on in TEGRA124
AbandonedPublic

Authored by imp on Aug 23 2018, 3:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 8:19 AM
Unknown Object (File)
Nov 11 2023, 2:40 PM
Unknown Object (File)
Nov 7 2023, 6:26 AM
Unknown Object (File)
Oct 6 2023, 5:22 AM
Unknown Object (File)
Sep 17 2023, 6:42 AM
Unknown Object (File)
Jul 4 2023, 2:08 AM
Unknown Object (File)
May 14 2023, 6:35 AM
Unknown Object (File)
Apr 25 2023, 6:33 PM

Details

Reviewers
mmel
mmacy
rgrimes
Summary

After much discussion, re-import the old drm2 base code (but not the
intel or radeon drivers) as a transition aide for TEGRA124. To make it
clear this is only for TEGRA, it's moving (without history) to
sys/arm/nvidia/drm2/dev/drm2. This will restore the status quo for the
TEGRA port so that it isn't broken just before 12.0 is branched.

However, this should be viewed as a stop-gap measure. Future graphics
support should be done via the new graphics group working to shim
drm-next into FreeBSD. All vestiges of drm2 support will be removed
in the run up to FreeBSD 13 release, or sooner if there's an suitable
solution for this platform available.

Approved by: mmacy@, mmel@, core@

Note: My plan for the actual repo commit is to svn cp sys/dev/drm2@338168 sys/arm/nvidia/drm2/dev/drm2 followed by a svn rm of the stuff not needed then apply the build patches, then do a commit so we have a nice, atomic bundle.

also, sys/arm/dev/drm2 is fine too if mmel thinks this will be used outside of tegra.

Test Plan

I have no ability to test this, but it compiles.

Diff Detail

Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsys/arm/nvidia/drm2/dev/drm2/drm_buffer.c:155SPELL1Possible Spelling Mistake
Warningsys/arm/nvidia/drm2/dev/drm2/drm_buffer.h:106SPELL1Possible Spelling Mistake
Warningsys/arm/nvidia/drm2/dev/drm2/drm_crtc_helper.c:544SPELL1Possible Spelling Mistake
Unit
No Test Coverage
Build Status
Buildable 19101
Build 18728: arc lint + arc unit

Event Timeline

imp added reviewers: mmel, mmacy.

There's three files that matter here, given my plan: sys/conf/Makefile.arm, sys/arm/conf/TEGRA124 and sys/arm/nvidia/tegra124/files.tegra124
The rest are just copies from dev/drm2 before the rm.

This revision is now accepted and ready to land.Aug 23 2018, 5:10 PM
rgrimes requested changes to this revision.Aug 23 2018, 5:49 PM
rgrimes added a subscriber: rgrimes.

I respectfully request that a straight revert of the commits be done rather than this, for one this does not allow us to do the proper deprecation commits, nor to merge those commits back to stable/11. This is still a major violation of deprecation policy. Warner, would you new policy allow this type of thing to be accepted? I would hope not.

Furthermore this differential is failing build, something we do not want hours before code freeze!

This revision now requires changes to proceed.Aug 23 2018, 5:49 PM

Furthermore this differential is failing build, something we do not want hours before code freeze!

Are you basing that on actually having downloaded the diff and built it, or are you basing that on Harbormaster pointing out spelling mistakes? https://reviews.freebsd.org/B19101 -- because if it's the latter, Harbormaster doesn't actually build things.

I respectfully request that a straight revert of the commits be done rather than this, for one this does not allow us to do the proper deprecation commits, nor to merge those commits back to stable/11. This is still a major violation of deprecation policy. Warner, would you new policy allow this type of thing to be accepted? I would hope not.

Furthermore this differential is failing build, something we do not want hours before code freeze!

It builds. I've built it 4 differnet times.