Fix IPV6_USE_MIN_MTU socket option for TCP sockets

[tuexen]

Summary

Is reported in PR173444 that using the IPV6_USE_MIN_MTU socket option on a TCP socket results in sending fragmented IPv6 packets.

The patch adds another flag to the in_conninfo flags. bz@ suggested in BSDCam to avoid this by passing the inp around, but this is not always available (from within the syncache code). Therefore, the TCP layer intercepts the IPPROTO_IPV6 level socket option, reduces the MSS or TCP connections when possible and marks them.

Although setting the socket option means that the application want to limit the size of TCP segments being sent, a value of 1220 is announced in the MSS option, if possible, since TCP usually is very conservative.

Test Plan

Run the following packetdrill scripts:

server-use-min-mtu-before-listen-ipv6.pkt2 KBDownload

server-use-min-mtu-before-listen-ipv4.pkt2 KBDownload

server-use-min-mtu-after-accept-ipv6.pkt2 KBDownload

server-use-min-mtu-after-accept-ipv4.pkt2 KBDownload

client-use-min-mtu-before-connect-ipv6.pkt2 KBDownload

client-use-min-mtu-before-connect-ipv4.pkt2 KBDownload

client-use-min-mtu-after-connect-ipv6.pkt2 KBDownload

client-use-min-mtu-after-connect-ipv4.pkt2 KBDownload

[bz]

I think it looks good; given you've done the testing.

sys/netinet/in_pcb.h

127 ↗

(On Diff #46903)

I just garbage collected this one.

sys/netinet/tcp_usrreq.c

1583 ↗

(On Diff #46903)

Do you want to add a comment here why you are doing this?

[tuexen]

Address comments from bz@

[tuexen]

sys/netinet/in_pcb.h

127 ↗

(On Diff #46903)

Great. Thank you.

sys/netinet/tcp_usrreq.c

1583 ↗

(On Diff #46903)

Done.