Page MenuHomeFreeBSD
Differential D16758

Make smsc(4) turbo_mode configuration
AcceptedPublic
Actions

Authored by jailbird_fdf.net on Aug 17 2018, 6:35 AM.
Tags
None
Referenced Files
F81535366: D16758.id46820.diff
Wed, Apr 17, 4:57 PM
Unknown Object (File)
Fri, Mar 29, 3:25 PM
Unknown Object (File)
Nov 8 2023, 3:06 PM
Unknown Object (File)
Nov 5 2023, 6:32 PM
Unknown Object (File)
Oct 7 2023, 1:55 PM
Unknown Object (File)
Oct 4 2023, 5:28 PM
Unknown Object (File)
Sep 15 2023, 10:59 PM
Unknown Object (File)
Aug 6 2023, 8:15 AM
View All 10 Files
Subscribers
0mp
imp
Contributor Reviews (src)

Details

Reviewers
0mp
imp
Group Reviewers
manpages
Summary

The current FreeBSD smsc(4) driver is hard-coded to always enable turbo_mode (coalesce multiple packets into one read). While this increases throughput, it can increase latency and jitter, which is detrimental to timekeeping (NTP) and possibly line UDP (like VoIP).

Because of this, the Linux version makes turbo_mode configurable. This patch does the same. The default leaves it enabled, like it currently is.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

jailbird_fdf.net created this revision.Aug 17 2018, 6:35 AM
Herald added a reviewer: manpages. · View Herald TranscriptAug 17 2018, 6:35 AM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript
0mp accepted this revision as: 0mp.Aug 17 2018, 9:13 AM
0mp added a subscriber: 0mp.

The manpage update looks fine.

share/man/man4/smsc.4
82

Just a minor style thing: do you think it's a nice idea to replace "turbo mode" with .Dq turbo mode?

86

I'd wrap 1 in Dq Li macros.

This revision is now accepted and ready to land.Aug 17 2018, 9:13 AM
imp accepted this revision.Aug 17 2018, 1:43 PM

seems reasonable to me. Haven't looked at the man page though.

0mp added inline comments.Aug 17 2018, 2:10 PM
share/man/man4/smsc.4
86

Also, I believe that you should close the Bl macro with El.

Try running mandoc -Tlint ./smsc.4 and igor ./smsc.4 to see if everything is fine with the mdoc syntax.

jailbird_fdf.net updated this revision to Diff 46869.Aug 18 2018, 4:33 AM
jailbird_fdf.net marked 3 inline comments as done.

Thanks for the pointers, I'm a newb at mdoc!

This one passes both checks!

This revision now requires review to proceed.Aug 18 2018, 4:33 AM
jailbird_fdf.net updated this revision to Diff 46871.Aug 18 2018, 7:04 AM

Got rid of redundant 'for' in man page

0mp accepted this revision as: 0mp.Sep 28 2018, 11:37 AM

Manpage changes seem fine! Thanks!

This revision is now accepted and ready to land.Sep 28 2018, 11:37 AM

Revision Contents
Changeset List

PathSize
share/
man/
man4/
17 lines
sys/
dev/
usb/
net/
21 lines

Diff 46869

View Options

share/man/man4/smsc.4

Loading...
View Options

sys/dev/usb/net/if_smsc.c

Loading...