Page MenuHomeFreeBSD

Make smsc(4) turbo_mode configuration
AcceptedPublic

Authored by jailbird_fdf.net on Aug 17 2018, 6:35 AM.

Details

Reviewers
0mp
imp
Group Reviewers
manpages
Summary

The current FreeBSD smsc(4) driver is hard-coded to always enable turbo_mode (coalesce multiple packets into one read). While this increases throughput, it can increase latency and jitter, which is detrimental to timekeeping (NTP) and possibly line UDP (like VoIP).

Because of this, the Linux version makes turbo_mode configurable. This patch does the same. The default leaves it enabled, like it currently is.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

0mp added a subscriber: 0mp.

The manpage update looks fine.

share/man/man4/smsc.4
82

Just a minor style thing: do you think it's a nice idea to replace "turbo mode" with .Dq turbo mode?

86

I'd wrap 1 in Dq Li macros.

This revision is now accepted and ready to land.Aug 17 2018, 9:13 AM

seems reasonable to me. Haven't looked at the man page though.

share/man/man4/smsc.4
86

Also, I believe that you should close the Bl macro with El.

Try running mandoc -Tlint ./smsc.4 and igor ./smsc.4 to see if everything is fine with the mdoc syntax.

jailbird_fdf.net marked 3 inline comments as done.

Thanks for the pointers, I'm a newb at mdoc!

This one passes both checks!

This revision now requires review to proceed.Aug 18 2018, 4:33 AM

Got rid of redundant 'for' in man page

Manpage changes seem fine! Thanks!

This revision is now accepted and ready to land.Sep 28 2018, 11:37 AM