Page MenuHomeFreeBSD

www/qt5-webengine: Add sndio support
ClosedPublic

Authored by tobik on Jul 21 2018, 5:11 PM.

Details

Summary

This adds the missing sndio support to qt5-webengine which allows
you to actually hear some audio on sndiod remotes in browsers like
Falkon etc.

I could not get something like QT_CONFIG+=sndio to work. It seems
to have no effect when I set it.

I believe that the ALSA option doesn't actually work in disabling
ALSA either. I still see use_alsa=true being added to gn_args
after turning off the option if alsa-lib is installed in the build
environment (see ${WRKDIR}/.build/qtwebengine-config.pri under
QT.webengine_private.enabled_features after make configure;
with ALSA=off it should *not* have alsa in it but currently does).
This should be fixed even though it's not a problem in Poudriere/Synth
builds. Passing -alsa / -no-alsa via QMAKE_CONFIGURE_ARGS works
here too.

I believe it's the same with PULSEAUDIO (which seems to be hard
disabled in freebsd.pri via use_pulseaudio=false for some reason,
so is currently broken anyway). Also see PR 226121 with the TrueOS
fixes that attempt to fix the PULSEAUDIO option.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18237
Build 17965: arc lint + arc unit

Event Timeline

tobik created this revision.Jul 21 2018, 5:11 PM
tcberner accepted this revision.Jul 21 2018, 6:01 PM
tcberner added a subscriber: tcberner.

if it works, ship it

This revision is now accepted and ready to land.Jul 21 2018, 6:01 PM
This revision was automatically updated to reflect the committed changes.