Page MenuHomeFreeBSD

graphics/fracplanet: update to 0.5.1
AbandonedPublic

Authored by swills on Jul 19 2018, 1:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 14 2024, 3:24 AM
Unknown Object (File)
Feb 19 2024, 10:07 PM
Unknown Object (File)
Feb 10 2024, 9:35 PM
Unknown Object (File)
Dec 23 2023, 2:28 AM
Unknown Object (File)
Dec 10 2023, 12:42 AM
Unknown Object (File)
Nov 9 2023, 10:55 PM
Unknown Object (File)
Nov 9 2023, 1:38 PM
Unknown Object (File)
Nov 4 2023, 10:02 PM
Subscribers

Details

Reviewers
None
Summary

See bugzilla PR 229874

Test Plan

Build tested in poudriere

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

fracplanet/Makefile
9

It would be better to:

  1. don't rename the package for the default flavor, so the Qt4 should not have a PKGNAMESUFFIX, so that people who run pkg upgrade don't wonder why it is gone.
  2. use <flavor>_PKGNAMESUFFIX helpers to set this.
47–54

This should go just after the USES block, like line 29 or something, see https://www.freebsd.org/doc/en/books/porters-handbook/porting-order-flavors.html

53

This does not seem to be used anywhere.

swills marked 3 inline comments as done.

Thanks, look good now?

fracplanet/Makefile
24

I would write qt5_PKGNAMESUFFIX=-qt5 so that it is simpler to read and faster to parse.