Passing UNRESTRICTED nsegments causes INT_MAX-sized array allocation in DMA
code. So it is utterly stupid to recommend it.
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 17999 Build 17751: arc lint + arc unit
Event Timeline
Comment Actions
Small textual suggestion.
share/man/man9/bus_dma.9 | ||
---|---|---|
433 | I'd remove the "So" and just start the sentence with "Users should ..." |
share/man/man9/bus_dma.9 | ||
---|---|---|
428 | I actually view it is an API bug and would kind of document it as such, something like: "BUS_SPACE_UNRESTRICTED cannot be used with nsegments as it is instead interpreted as a very large segment count. OTOH, I would actually like it if we had a non-terrible way to support BUS_SPACE_UNRESTRICTED such as clamping 'nsegments' at some value like 64, I just don't feel confident in picking that number. |