Introduce PMCR-based cpufreq(4) driver, for IBM POWER9 systems
ClosedPublic
Actions

Authored by jhibbits on Jun 20 2018, 7:08 PM.

Details

Reviewers

Commits

rS335481: Introduce PMCR-based cpufreq(4) driver, for IBM POWER8 and POWER9 systems

Summary

POWER9 uses a single CPU register, per core, to change clock speed. Everything else is handled by the on-chip controller. This change necessitates a change to the cpufreq global kernel driver to bump supported levels, as the POWER9 device tree can have theoretically 256 different options. On my POWER9 Talos, the list consists of 100 items. At 16.67MHz intervals, that allows for a change of roughly 1.67GHz between lowest and highest.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17492
Build 17320: arc lint + arc unit

Event Timeline

jhibbits created this revision.Jun 20 2018, 7:08 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 20 2018, 7:08 PM

Harbormaster completed remote builds in B17492: Diff 44175.Jun 20 2018, 7:08 PM

Looks good to me.

sys/powerpc/cpufreq/pmcr.c
129	How POWER9-specific is this?

This revision is now accepted and ready to land.Jun 21 2018, 4:56 AM

jhibbits added inline comments.Jun 21 2018, 1:41 PM

sys/powerpc/cpufreq/pmcr.c
129	Currently it's very specific, because of the masking involved. I just checked on the POWER8, and that device tree also does include the requisite properties, but the format appears different from the POWER9, so I'm reluctant at this time to open this up to that as well. Once I figure out the POWER8 format, I can make it work for that with this same driver.