Build framework changes for OpenSSL 1.1
AbandonedPublic
Actions

Authored by brnrd on Jun 13 2018, 3:38 PM.

Details

Reviewers

gordon
jkim
bdrewery

Summary

Changes to the build-framework only (for now)

This does currently _not_ include:

Update of crypto/openssl
Updated manpages
Updated asm files

See also: FreeBSD Wiki page documenting updating OpenSSL in base

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17280
Build 17117: arc lint + arc unit

Event Timeline

brnrd created this revision.Jun 13 2018, 3:38 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 13 2018, 3:38 PM

Harbormaster completed remote builds in B17235: Diff 43711.Jun 13 2018, 3:38 PM

brnrd edited the summary of this revision. (Show Details)Jun 13 2018, 3:41 PM

Buildable libcrypto/libssl/openssl

Does require the generated files in crypto/openssl

Harbormaster completed remote builds in B17280: Diff 43779.Jun 14 2018, 6:54 PM

Seems fine. What generated files are you talking about exactly?

secure/lib/libcrypto/Makefile.inc
7	I think date needs bump?

brnrd marked an inline comment as done.Jun 20 2018, 11:05 AM

brnrd added inline comments.

secure/lib/libcrypto/Makefile.inc
7	I thought so too, but 1.0.2o and 1.1.0h were security fix releases on the same date for 1.0.2 and 1.1.0 branches. See the OpenSSL download page as well.

In D15791#336576, @bdrewery wrote:

Seems fine. What generated files are you talking about exactly?

The build needs the following generated files that are dependent on architecture and OS
{{{
include/openssl/opensslconf.h
crypto/include/internal/bn_conf.h
crypto/include/internal/dso_conf.h
}}}
See also [[ https://wiki.freebsd.org/OpenSSL/Base/OpenSSL/Base/Update | Generate .h files on the FreeBSD wiki page ]]. That page contains more detail on the process than this review.