Open source toolchain for Lattice ICE40 FPGAs
ClosedPublic
Actions

Authored by jsorocil_gmail.com on May 31 2018, 11:40 AM.

Details

Reviewers

Commits

rP471848: New port: devel/lattice-ice40-tools
rP471847: New port: devel/lattice-ice40-examples-hx8k
rP471846: New port: devel/lattice-ice40-examples-hx1k
rP471844: New port: devel/yosys
rP471842: New port: devel/arachne-pnr
rP471841: New port: devel/icestorm

Summary

Initial commit.

Consists of:

abc
yosys
arachne-pnr
icestorm tools
examples for Olimex FPGA HX1K and HX8K boards

metaports:

lattice-ice40-tools
lattice-ice40-examples

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jsorocil_gmail.com created this revision.May 31 2018, 11:40 AM

Harbormaster completed remote builds in B16943: Diff 43197.May 31 2018, 11:40 AM

kbowling added a subscriber: kbowling.May 31 2018, 5:38 PM

Context: https://forums.freebsd.org/threads/new-ports-lattice-fpga-tools.65552/

devel/abc/Makefile
11–12 ↗	(On Diff #43197)	You probably need to define your own license for it. It seems like a weird variant of the MIT license.
devel/icestorm/Makefile
29 ↗	(On Diff #43197)	post-install
devel/lattice-ice40-examples/Makefile
11 ↗	(On Diff #43197)	This isn't needed. A metaport installs no files so it also doesn't need a license.
18 ↗	(On Diff #43197)	This port should probably just be added as an EXAMPLES option to `lattice-ice40-tools`.
20–21 ↗	(On Diff #43197)	Not needed for metaports.
devel/lattice-ice40-tools/Makefile
12 ↗	(On Diff #43197)	metaport => no license
19–20 ↗	(On Diff #43197)	Not needed for metaports.
devel/lattice-ice40-tools/pkg-descr
6 ↗	(On Diff #43197)	Hmm, I don't think it makes sense to list the web sites of all the ports metaports depend on.
devel/yosys/Makefile
28 ↗	(On Diff #43197)	`s/+=/=/`. Also needs to be earlier after BUILD_DEPENDS.
43 ↗	(On Diff #43197)	Would it be possible to do this earlier in post-patch?

This revision now requires changes to proceed.Jun 1 2018, 9:46 AM

jsorocil_gmail.com marked 9 inline comments as done.Jun 3 2018, 6:38 PM

jsorocil_gmail.com added inline comments.

devel/lattice-ice40-tools/pkg-descr
6 ↗	(On Diff #43197)	Is it OK to have just the first site then?
devel/yosys/Makefile
43 ↗	(On Diff #43197)	I don't think so because yosys-smtbmc file is not created after "make patch" is executed.

Review1 for FPGA toolchain

Changes made according to review comments on reviews.freebsd.org
- lattice-ice40-examples metaport removed
- examples added as an opntion to lattice-ice40-tools metaport
- mail address changed to jsorocil
- set tab to 8 spaces and realign Makefiles.

Harbormaster completed remote builds in B16988: Diff 43287.Jun 3 2018, 6:40 PM

Ok.

I'll land this in several commits with some minor changes. Phabricator will probably auto-update this review with only the first commit. I'll post a comment here with links to all commits after I'm done so you can check that I did this right.

This revision is now accepted and ready to land.Jun 6 2018, 12:49 PM

Closed by commit rP471841: New port: devel/icestorm (authored by tobik). · Explain WhyJun 6 2018, 1:33 PM

This revision was automatically updated to reflect the committed changes.

Ok. I committed everything except abc which was already in the ports tree as cad/abc.

@jsorocil_gmail.com Since you changed your email address it would be good to update your Bugzilla mail address to the same as well so that you can be correctly CC'ed by Bugzilla and can be recognized by us as the maintainer.

Commits: rP471841 rP471842 rP471844 rP471846 rP471847 rP471848

In D15632#331351, @tobik wrote:

@jsorocil_gmail.com Since you changed your email address it would be good to update your Bugzilla mail address to the same as well so that you can be correctly CC'ed by Bugzilla and can be recognized by us as the maintainer.

Done.