audio/mixxx update to 2.1.4

[acm]

Summary

• Add qt4|qt5 FLAVORS

Test Plan

Tested on poudriere 11-amd64

https://people.freebsd.org/~acm/ports/logs/mixxx-qt4-2.1.0.log
https://people.freebsd.org/~acm/ports/logs/mixxx-qt5-2.1.0.log

[mat]

mixxx/Makefile

1 ↗

(On Diff #41790)

The only case where you can remove this line is if the person in it asked you to. In all other cases, it is write-only.

7 ↗

(On Diff #41790)

The distribution file name is too generic, please use DIST_SUBDIR.

33 ↗

(On Diff #41790)

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

35–36 ↗

(On Diff #41790)

Wrong place in the Makefile.

38 ↗

(On Diff #41790)

Wrong place in the Makefile.

41–53 ↗

(On Diff #41790)

Wrong place in the Makefile.

63–66 ↗

(On Diff #41790)

Wrong place in the Makefile.

[acm]

• Apply changes according mat commentaries

[mat]

Makefile

6–7

Sorry, missed the fact that you were not using USE_GITHUB like you should, here, add:

DISTVERSIONPREFIX=release-

and later, add:

USE_GITHUB=yes
GH_ACCOUNT=mixxxdj

70

Remove.

96–102

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

[acm]

• Apply changes according mat commentaries

[acm]

• Update patch file with right version

[mat]

mixxx/Makefile

5 ↗

(On Diff #43347)

You should probably be using DISTVERSION.

8 ↗

(On Diff #43347)

Not required, could be removed.

35–36 ↗

(On Diff #43347)

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

83–96 ↗

(On Diff #43347)

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

[acm]

• Apply changes accord to mat commentaries

[acm]

• Migrate to new QT helpers

[mat]

Makefile

33–34

You should probably help to set FLAVOR here, you could drop all :U* dances later, see https://www.freebsd.org/doc/en/books/porters-handbook/flavors-using.html

46

Default, please remove.

[acm]

• Apply mat's suggestions

[mat]

Makefile

36–37

Not exactly sure why using flavors helpers for this, it is the same value for both.

[acm]

• Add missing items to flavor_CONFLICTS

[mat]

mixxx/Makefile

46 ↗

(On Diff #46373)

There is a release-2.1.1 you can use:

DISTVERSIONPREFIX=  release-

[acm]

• Update to 2.1.3
• Add DISTVERSIONPREFIX
• Add CONFLICTS

[mat]

mixxx/Makefile

5 ↗

(On Diff #47473)

This should probably be DISTVERSION.

18 ↗

(On Diff #47473)

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

[acm]

• Update to 2.1.4
• Some minor changes

[acm]

• Remove FLAVOR support. QT4 will be deprecated soon. it'll use QT instead of