- Add qt4|qt5 FLAVORS
Details
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
mixxx/Makefile | ||
---|---|---|
1 | The only case where you can remove this line is if the person in it asked you to. In all other cases, it is write-only. | |
9 | The distribution file name is too generic, please use DIST_SUBDIR. | |
37–38 | Wrong place in the Makefile. | |
38 | Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles. | |
40 | Wrong place in the Makefile. | |
47–59 | Wrong place in the Makefile. | |
57–60 | Wrong place in the Makefile. |
Makefile | ||
---|---|---|
7–9 ↗ | (On Diff #43008) | Sorry, missed the fact that you were not using USE_GITHUB like you should, here, add: DISTVERSIONPREFIX=release- and later, add: USE_GITHUB=yes GH_ACCOUNT=mixxxdj |
47 ↗ | (On Diff #43008) | Remove. |
75–81 ↗ | (On Diff #43008) | Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles. |
mixxx/Makefile | ||
---|---|---|
5–6 | You should probably be using DISTVERSION. | |
8 | Not required, could be removed. | |
35–37 | Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles. | |
83–96 | Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles. |
Makefile | ||
---|---|---|
33 ↗ | (On Diff #46254) | You should probably help to set FLAVOR here, you could drop all :U* dances later, see https://www.freebsd.org/doc/en/books/porters-handbook/flavors-using.html |
45 ↗ | (On Diff #46254) | Default, please remove. |
Makefile | ||
---|---|---|
36–37 ↗ | (On Diff #46351) | Not exactly sure why using flavors helpers for this, it is the same value for both. |
mixxx/Makefile | ||
---|---|---|
50 | There is a release-2.1.1 you can use: DISTVERSIONPREFIX= release- |
mixxx/Makefile | ||
---|---|---|
5–6 | This should probably be DISTVERSION. | |
19 | Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles. |