biology/bamtools: API and toolkit for handling BAM files
Approved by jrm (mentor) or wen (mentor)
Differential to be added to commit message
Details
- Reviewers
jrm wen - Commits
- rP465808: biology/bamtools: API and toolkit for handling BAM files
Passed pkglint and stage-qa
Poudriere tested on {10.3,11.1}-{amd64,i386}
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 15840 Build 15848: arc lint + arc unit
Event Timeline
Looks good.
biology/bamtools/Makefile | ||
---|---|---|
20 | Does this need to be +=? | |
biology/bamtools/pkg-descr | ||
3 | Would an opening paragraph describing BAM be useful? (I was not able to put this above the first sentence.) `BAM is the binary alternative to the sequence alignment/map (SAM) format |
Yes, I did overlook your comment.
I've developed a habit of using += for any sort of configure arguments, out of paranoia over clobbering those that ports injects on its own. I can change this one to '='.
There were two comments. It's up to you. Committing now doesn't affect much (other than the change itself) if you don't have to bump PORTREVISION. If you decided to make a change to pkg-desc, that probably warrants a PORTREVISION bump though.
I'll leave it alone for now rather than add noise to the commit log.
I added the changes to wip/bamtools to make sure they'll be included in the next upgrade.
Thanks for the improved description. I would not have come up with that on my own, as I'm not a bioinformatician.