Page MenuHomeFreeBSD

New port: devel/shellcheck shellcheck is a lint-like tool for shell scripts. It has a web version, but it can be used as a stand alone tool. It's been useful to me several times. The port compiles fine (I didn't attach the logs yet) but there...
AbandonedPublic

Authored by fernape on Mar 18 2018, 6:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 6:42 AM
Unknown Object (File)
Jul 6 2023, 10:04 PM
Unknown Object (File)
Mar 21 2023, 11:52 AM
Unknown Object (File)
Mar 3 2023, 4:28 PM
Unknown Object (File)
Dec 31 2022, 8:54 PM
Subscribers

Details

Reviewers
tz
tcberner
Summary

...are some things
that bug me: the long BUILD_DEPENDS lines. Is it possible specify the dependency
in any other way?

Also, some of the dependencies are from files in ${LOCALBASE}/lib/cabal/ghc-8.0.2

Does this mean the port will break if ghc is updated to, say 8.0.3?

Thanks!

New port: devel/shellcheck

Test Plan

cd devel/shellcheck && portlint -AC && make

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 15638
Build 15673: arc lint + arc unit

Event Timeline

tcberner added inline comments.
devel/shellcheck/Makefile
1

^ Created by should not be added to new ports

18

There is USE_CABAL=...

20

^ no need for +=

22
24

^no need for +?

27

GH_PROJECT is not necessary, as the defualt is ${PORTNAME} [1]

[1] https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.html section 5.4.3

30

^ check the other hs-* ports on how they do this step -- all the magic is already present by including bsd.cabal.mk.

This revision now requires changes to proceed.Mar 18 2018, 9:14 PM

We already have this in devel/hs-ShellCheck: