Differential D14586

textproc/py-qt5-xml: Install Python bytecode
ClosedPublic
Actions

Authored by jhale on Mar 5 2018, 4:29 PM.

Details

Reviewers

tcberner

Group Reviewers

kde

Commits

rP463772: textproc/py-qt5-xml:

Summary

py-qt5-xml does not currently install pre-compiled Python bytecode
which can cause build errors in poudriere for ports depending on it. If
the bytecode is not pre-installed, when the module is loaded Python creates
the bytecode on the fly causing the filesystem to be touched during the
build. For example:

http://package21.nyi.freebsd.org/data/111amd64-default-qat/463452/logs/errors/Carla-1.9.8.log

Test Plan

Standard poudriere test builds completed with py27 and py36 flavor on 11.0 amd64

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhale created this revision.Mar 5 2018, 4:29 PM

Harbormaster completed remote builds in B15372: Diff 39959.Mar 5 2018, 4:29 PM

Herald added a subscriber: mat. · View Herald TranscriptMar 5 2018, 4:29 PM

antoine added a subscriber: antoine.Mar 5 2018, 4:40 PM

antoine added inline comments.

textproc/py-qt5-xml/Makefile
31 ↗	(On Diff #39959)	The backtraces will be wrong. It should be ${PYTHON_CMD} ${PYTHON_LIBDIR}/compileall.py \ -f -d ${PYTHONPREFIX_SITELIBDIR}/PyQt5 \ ${STAGEDIR}${PYTHONPREFIX_SITELIBDIR}/PyQt5