Differential D14510

Fix two memory leaks in syslogd
ClosedPublic
Actions

Authored by dab on Feb 26 2018, 1:05 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Jan 31 2024, 8:47 AM

	Unknown Object (File)
	Jan 31 2024, 4:42 AM

	Unknown Object (File)
	Dec 20 2023, 6:45 AM

	Unknown Object (File)
	Nov 14 2023, 5:02 AM

	Unknown Object (File)
	Sep 15 2023, 7:03 AM

	Unknown Object (File)
	Aug 28 2023, 1:31 AM

	Unknown Object (File)
	Aug 23 2023, 5:07 PM

	Unknown Object (File)
	Aug 13 2023, 4:58 AM

View All 26 Files

Subscribers

Details

Reviewers

Commits

rS330034: Fix two memory leaks in syslogd

Summary

Bug 198385
reports a memory leak in processing of forward actions. This
modification adapts the patch submitted with that bug (by Sreeram) to
fix the leak. While testing the modification, another leak was also
found and fixed.

Submitted by: Sreeram

Test Plan

Run valgrind on syslogd with at least one forward entry
(i.e., an action of @some-host). Send SIGHUP several times so that the
configuration file is reloaded. Send SIGTERM to terminate
syslogd. Before the change, multiple blocks of memory are reported to
have been leaked. After the change, no leaks are shown:

==34004== LEAK SUMMARY:
==34004==    definitely lost: 0 bytes in 0 blocks
==34004==    indirectly lost: 0 bytes in 0 blocks
==34004==      possibly lost: 0 bytes in 0 blocks

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dab created this revision.Feb 26 2018, 1:05 AM

Herald added subscribers: badger, vangyzen, imp. · View Herald TranscriptFeb 26 2018, 1:05 AM

Harbormaster completed remote builds in B15267: Diff 39725.Feb 26 2018, 1:05 AM

dab edited the summary of this revision. (Show Details)Feb 26 2018, 1:14 AM

dab edited the test plan for this revision. (Show Details)

dab edited the test plan for this revision. (Show Details)

Looks good to me. Thank you for taking care of it!

This revision is now accepted and ready to land.Feb 26 2018, 1:20 AM

Closed by commit rS330034: Fix two memory leaks in syslogd (authored by dab). · Explain WhyFeb 26 2018, 7:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

syslogd/

15 lines

Diff 39768

head/usr.sbin/syslogd/syslogd.c

Loading...