Add srtp flavor to asterisk13 to generate a binary package with SRTP support

[madpilot]

Summary

I'd like the asterisk port to also generate a flavor witht he SRTP
option turned on.

I don't fdeel comfortable simply enabling the SRTP option by default
die to the problems described in UPDATING entries 20150323 and
20150506, due to non trivial interactions with other ports.

Having two flavors would at least leave the normal one working in
such a situation.

Test Plan

Port already works when correctly compiled with SRTP support

[mat]

Why not simply add it to the default options ?

[madpilot]

In D14292#303087, @mat wrote:

Why not simply add it to the default options ?

Well when I did that in the past it ended up causing a broken binary(as in dumping core on startup) to be generated on 9.x due to modules dependencies being linked to different ssl libraries. Main problem was libcurl linking to ports provided SSL, through a dependency of it's own. (see UPDATING 20150323 and 20150506)

I think the curl issue is solved, but I'd like to decouple the option to avoid braking the main port for everyone.

I'd like to enable the option by default actually, but I'm not completely sure the underlying issue is fixed for good. This would be a good way to test this too, without creating too much problems.

[madpilot]

After some more tests and thought I agree this is better done with the option in the unflavored port.

Creating a flavor also brings problems with dependencies which I did not foresee.

Thanks for having taken a look at this!

[mat]

In D14292#303088, @madpilot wrote:

In D14292#303087, @mat wrote:

Why not simply add it to the default options ?

Well when I did that in the past it ended up causing a broken binary(as in dumping core on startup) to be generated on 9.x due to modules dependencies being linked to different ssl libraries. Main problem was libcurl linking to ports provided SSL, through a dependency of it's own. (see UPDATING 20150323 and 20150506)

I think the curl issue is solved, but I'd like to decouple the option to avoid braking the main port for everyone.

I'd like to enable the option by default actually, but I'm not completely sure the underlying issue is fixed for good. This would be a good way to test this too, without creating too much problems.

There are only two ports that always link to the base openssl, it is pkg (because no dependency) and net-snmp because it links with libpkg and mixing ssl variants is bad.

There are no ports that will forcefully install and like with ports openssl.

(I know, I cleaned up everything)

[madpilot]

In D14292#303378, @mat wrote:

There are only two ports that always link to the base openssl, it is pkg (because no dependency) and net-snmp because it links with libpkg and mixing ssl variants is bad.

There are no ports that will forcefully install and like with ports openssl.

(I know, I cleaned up everything)

Thanks for clearing that up...both my doubt in this comment and, most important, doing the actual cleanup!