Differential D14073

lang/ruby25: parse.y (assignable_gen): should return valid NODE always even on errors.
ClosedPublic
Actions

Authored by vishwin on Jan 27 2018, 3:44 PM.

Tags

Referenced Files

	F81404430: D14073.id38742.diff
	Mon, Apr 15, 8:43 PM

	F81404422: D14073.id39370.diff
	Mon, Apr 15, 8:43 PM

	F81404411: D14073.id.diff
	Mon, Apr 15, 8:42 PM

	F81404398: D14073.id38529.diff
	Mon, Apr 15, 8:42 PM

	Unknown Object (File)
	Tue, Apr 9, 12:58 PM

	Unknown Object (File)
	Feb 25 2024, 5:28 PM

	Unknown Object (File)
	Feb 23 2024, 1:52 AM

	Unknown Object (File)
	Jan 24 2024, 9:41 AM

View All 58 Files

Subscribers

Details

Reviewers

Group Reviewers

Ruby
portmgr
O5: Ports Framework

Commits

rP461970: lang/ruby25: apply upstream patch to fix segfault

Summary

Bug and patches originally obtained from upstream. Additional patches were "manually" generated when ruby's build system detected changes in the initial files patched.

Fixes a crash when installing/staging certain gems, for which in a portbuild situation, the build fails during stage. See bug 225470 for a partial trace of ruby25 segfaulting on devel/rubygem-ffi.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vishwin created this revision.Jan 27 2018, 3:44 PM

Herald added a reviewer: portmgr. · View Herald TranscriptJan 27 2018, 3:44 PM

Herald added a subscriber: mat. · View Herald Transcript

mat edited reviewers, added: swills; removed: portmgr.Jan 29 2018, 11:35 AM

Herald added a reviewer: portmgr. · View Herald TranscriptJan 29 2018, 11:35 AM

Regenerate with devel/arcanist

Owners added a reviewer: O5: Ports Framework.Jan 31 2018, 8:07 PM

Harbormaster completed remote builds in B14715: Diff 38742.Jan 31 2018, 8:07 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 16 2018, 3:11 AM

Closed by commit rP461970: lang/ruby25: apply upstream patch to fix segfault (authored by swills). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Packages

head/

Mk/

2 lines

O5: Ports Framework

lang/

ruby25/

files/

patch-ext_ripper_ripper.c

5011 lines

patch-ext_ripper_ripper.y

45 lines

4926 lines

45 lines

patch-test_ruby_test__parse.rb

15 lines

Diff 39370

head/Mk/bsd.ruby.mk

Loading...

head/lang/ruby25/files/patch-ext_ripper_ripper.c

Loading...

head/lang/ruby25/files/patch-ext_ripper_ripper.y

Loading...

head/lang/ruby25/files/patch-parse.c

Loading...

head/lang/ruby25/files/patch-parse.y

Loading...

head/lang/ruby25/files/patch-test_ruby_test__parse.rb

Loading...