Page MenuHomeFreeBSD
Differential D14073

lang/ruby25: parse.y (assignable_gen): should return valid NODE always even on errors.
ClosedPublic
Actions

Authored by vishwin on Jan 27 2018, 3:44 PM.
Tags
Referenced Files
Unknown Object (File)
Sun, Apr 12, 2:55 AM
Unknown Object (File)
Fri, Apr 10, 1:02 AM
Unknown Object (File)
Thu, Apr 9, 1:44 PM
Unknown Object (File)
Mon, Apr 6, 4:18 PM
Unknown Object (File)
Mon, Apr 6, 7:59 AM
Unknown Object (File)
Mon, Apr 6, 2:44 AM
Unknown Object (File)
Sun, Apr 5, 11:55 PM
Unknown Object (File)
Mon, Mar 30, 6:59 AM
View All Files
Subscribers
mat
Ruby

Details

Reviewers
swills
Group Reviewers
Ruby
portmgr
O5: Ports Framework(Owns No Changed Paths)
Commits
rP461970: lang/ruby25: apply upstream patch to fix segfault
Summary

Bug and patches originally obtained from upstream. Additional patches were "manually" generated when ruby's build system detected changes in the initial files patched.

Fixes a crash when installing/staging certain gems, for which in a portbuild situation, the build fails during stage. See bug 225470 for a partial trace of ruby25 segfaulting on devel/rubygem-ffi.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 14715
Build 14837: arc lint + arc unit

Event Timeline

vishwin created this revision.Jan 27 2018, 3:44 PM
Herald added a reviewer: portmgr. · View Herald TranscriptJan 27 2018, 3:44 PM
Herald added a subscriber: mat. · View Herald Transcript
mat edited reviewers, added: swills; removed: portmgr.Jan 29 2018, 11:35 AM
Herald added a reviewer: portmgr. · View Herald TranscriptJan 29 2018, 11:35 AM
vishwin updated this revision to Diff 38742.Jan 31 2018, 8:07 PM

Regenerate with devel/arcanist

Owners added a reviewer: O5: Ports Framework.Jan 31 2018, 8:07 PM
Harbormaster completed remote builds in B14715: Diff 38742.Jan 31 2018, 8:07 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 16 2018, 3:11 AM
Closed by commit rP461970: lang/ruby25: apply upstream patch to fix segfault (authored by swills). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
Mk/
2 lines
lang/
ruby25/
files/
5011 lines
45 lines
4926 lines
45 lines
15 lines

Diff 38742

View Options

Mk/bsd.ruby.mk

Loading...
View Options

lang/ruby25/files/patch-ext_ripper_ripper.c

Loading...
View Options

lang/ruby25/files/patch-ext_ripper_ripper.y

Loading...
View Options

lang/ruby25/files/patch-parse.c

Loading...
View Options

lang/ruby25/files/patch-parse.y

Loading...
View Options

lang/ruby25/files/patch-test_ruby_test__parse.rb

Loading...