Previously the AIO subsystem would save a snapshot of the currently
configured per-process limits the first time a process used AIO. The
process would continue to use the snapshotted limits ignoring any
changes to the global limits during the rest of its lifetime. This
change removes the snapshotted values and changes the AIO code to
always check the global values which can be toggled at runtime.
This means an administrator can now change the effective limits of
existing processes. This is more consistent with how other limits
configured via sysctl work in FreeBSD.
Details
Details
- Reviewers
kib asomers - Commits
- rS327792: Don't store shadow copies of per-process AIO limits.
- run AIO tests from test suite (still waiting for run with enable_unsafe=1 to complete)
Diff Detail
Diff Detail
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 14235 Build 14398: arc lint + arc unit
Event Timeline
Comment Actions
Other than the descriptions, it all LGTM.
| sys/kern/vfs_aio.c | ||
|---|---|---|
| 169 | You should fix the description here and on lines 174 and 178. | |
| sys/kern/vfs_aio.c | ||
|---|---|---|
| 169 | Oops, yeah. I had noticed those earlier but forgotten to include them in the change. Thanks. | |