Page MenuHomeFreeBSD
Differential D13809

security/libdecaf: Some new fixes (in summary).
ClosedPublic
Actions

Authored by krion on Jan 9 2018, 8:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 1 2024, 1:25 AM
Unknown Object (File)
Aug 2 2023, 10:06 AM
Unknown Object (File)
Jul 15 2023, 4:35 PM
Unknown Object (File)
Jun 13 2023, 8:11 AM
Unknown Object (File)
Nov 26 2022, 3:56 PM
Subscribers
linimon

Details

Reviewers
mat
linimon
Summary
  • Remove explicit -march=native declaration.
  • Mark ONLY_FOR_ARCHS=amd64 (failures on other archs reported to upstream).
  • Install include files.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 14214
Build 14377: arc lint + arc unit

Event Timeline

krion created this revision.Jan 9 2018, 8:53 AM
Harbormaster completed remote builds in B14214: Diff 37673.Jan 9 2018, 8:53 AM
linimon retitled this revision from Some new fixes (in summary). to security/libdecaf: Some new fixes (in summary)..Jun 18 2018, 9:35 PM
linimon added a subscriber: linimon.
mat added inline comments.Jun 18 2018, 9:58 PM
security/libdecaf/Makefile
15

Would be nice to have a _REASON for this, to help people understand what is broken exactly.

19–20
USES=localbase:ldflags

?

28

NEVER, EVER, use CP to install files.

Use one of the INSTALL_* or COPYTREE_* macros. Here, I think COPYTREE_SHARE would be appropriate.

linimon accepted this revision.Jul 19 2018, 2:51 AM

Already committed as r458613.

This revision is now accepted and ready to land.Jul 19 2018, 2:51 AM
linimon closed this revision.Jul 19 2018, 2:52 AM

Already committed as r458613 and r458614.

Revision Contents
Changeset List

PathSize
security/
libdecaf/
8 lines
files/
15 lines
23 lines

Diff 37673

View Options

security/libdecaf/Makefile

Loading...
View Options

security/libdecaf/files/patch-Makefile

Loading...
View Options

security/libdecaf/pkg-plist

Loading...