New port: sysutils/vzvol: Feature-rich ZFS zvol management tool
AbandonedPublic

Authored by yuri on Fri, Dec 29, 5:15 AM.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13949
Build 14144: arc lint + arc unit
yuri created this revision.Fri, Dec 29, 5:15 AM
mat added inline comments.Fri, Dec 29, 9:51 AM
sysutils/vzvol/Makefile
44

This seems like it is installing scripts, maybe you should use INSTALL_SCRIPT. Also, I am not sure there is a point of installing the Linux related scripts.

48

Never, never, never, never, use cp to install files in STAGEDIR.
In this case, you should probably use ${COPYTREE_SHARE}.

tcberner added inline comments.Fri, Dec 29, 9:50 PM
sysutils/vzvol/pkg-plist
20

^ also, call me out on my prejudice, but given that these are linux scripts, I would assume you need a bash runtime dependency?

yuri marked 3 inline comments as done.Fri, Dec 29, 10:41 PM
yuri added inline comments.
sysutils/vzvol/pkg-plist
20

No, I checked scripts and they are meant to be Bourne shell.

However, shellcheck finds some errors in them. I asked upstream to correct and create a release.

IMO, it will be reasonable to wait a few days in a hope that they will respond.

yuri updated this revision to Diff 37202.Fri, Dec 29, 10:41 PM
yuri marked an inline comment as done.

.

yuri marked an inline comment as done.Fri, Dec 29, 10:41 PM
yuri added inline comments.Fri, Dec 29, 10:43 PM
sysutils/vzvol/Makefile
44

I am not sure there is a point of installing the Linux related scripts.

These are for Linux file systems, not for Linux itself. They allow to manage Linux filesystems like ext2.

yuri retitled this revision from New port: sysutils/vzvol: Feature-rich ZFS zvol management tool to New port: sysutils/vzvol: Feature-rich ZFS zvol management tool {hold waiting for upstream scripts update, or until Dec 31}.Fri, Dec 29, 10:45 PM
tcberner added inline comments.Fri, Dec 29, 11:04 PM
sysutils/vzvol/pkg-plist
20

good job :)

yuri added a comment.Sat, Dec 30, 6:09 PM

Surely enough, the upstream updated it.

yuri retitled this revision from New port: sysutils/vzvol: Feature-rich ZFS zvol management tool {hold waiting for upstream scripts update, or until Dec 31} to New port: sysutils/vzvol: Feature-rich ZFS zvol management tool.Sat, Dec 30, 6:09 PM
yuri added a comment.Wed, Jan 3, 9:00 PM

Submitter asked to transfer it to freebsdfrau to expedite this item.

She is welcome to take it!

yuri abandoned this revision.Thu, Jan 4, 10:04 AM

Committed by dteske@ on request by the submitter to avoid long a wait while it awaits approval.