sysutils/vzvol/Makefile
44	This seems like it is installing scripts, maybe you should use `INSTALL_SCRIPT`. Also, I am not sure there is a point of installing the Linux related scripts.
48	Never, never, never, never, use `cp` to install files in `STAGEDIR`. In this case, you should probably use `${COPYTREE_SHARE}`.

tcberner added inline comments.Dec 29 2017, 9:50 PM

sysutils/vzvol/pkg-plist
20	^ also, call me out on my prejudice, but given that these are `linux` scripts, I would assume you need a bash runtime dependency?

yuri marked 3 inline comments as done.Dec 29 2017, 10:41 PM

yuri added inline comments.

sysutils/vzvol/pkg-plist
20	No, I checked scripts and they are meant to be Bourne shell. However, `shellcheck` finds some errors in them. I asked upstream to correct and create a release. IMO, it will be reasonable to wait a few days in a hope that they will respond.

Harbormaster completed remote builds in B13928: Diff 37202.Dec 29 2017, 10:41 PM

yuri marked an inline comment as done.Dec 29 2017, 10:41 PM

yuri added inline comments.Dec 29 2017, 10:43 PM

sysutils/vzvol/Makefile
44	I am not sure there is a point of installing the Linux related scripts. These are for `Linux` file systems, not for `Linux` itself. They allow to manage `Linux` filesystems like `ext2`.

yuri retitled this revision from New port: sysutils/vzvol: Feature-rich ZFS zvol management tool to New port: sysutils/vzvol: Feature-rich ZFS zvol management tool {hold waiting for upstream scripts update, or until Dec 31}.Dec 29 2017, 10:45 PM

tcberner added inline comments.Dec 29 2017, 11:04 PM

sysutils/vzvol/pkg-plist
20	good job :)

Harbormaster completed remote builds in B13949: Diff 37238.Dec 30 2017, 6:08 PM

Surely enough, the upstream updated it.

yuri retitled this revision from New port: sysutils/vzvol: Feature-rich ZFS zvol management tool {hold waiting for upstream scripts update, or until Dec 31} to New port: sysutils/vzvol: Feature-rich ZFS zvol management tool.Dec 30 2017, 6:09 PM

Submitter asked to transfer it to freebsdfrau to expedite this item.

She is welcome to take it!

Committed by dteske@ on request by the submitter to avoid long a wait while it awaits approval.