Differential D13601

Fix several typos and minor errors
ClosedPublic
Actions

Authored by eadler on Dec 24 2017, 1:39 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Dec 20 2023, 4:39 AM

	Unknown Object (File)
	Nov 26 2023, 10:48 PM

	Unknown Object (File)
	Nov 24 2023, 6:53 PM

	Unknown Object (File)
	Nov 10 2023, 4:37 AM

	Unknown Object (File)
	Nov 8 2023, 4:44 AM

	Unknown Object (File)
	Nov 1 2023, 12:28 PM

	Unknown Object (File)
	Nov 1 2023, 8:54 AM

	Unknown Object (File)
	Oct 23 2023, 5:53 PM

View All 17 Files

Subscribers

Details

Reviewers

sbruno
benno

Group Reviewers

Intel Networking

Summary

I do not plan on committing this all at once, but letting this be a
single review reduces overall spam

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13773
Build 13987: arc lint + arc unit

Event Timeline

eadler created this revision.Dec 24 2017, 1:39 AM

Herald added a reviewer: sbruno. · View Herald TranscriptDec 24 2017, 1:39 AM

Herald added a reviewer: Intel Networking. · View Herald Transcript

Herald added subscribers: ae, jhibbits, emaste, imp. · View Herald Transcript

eadler added a reviewer: Src Committers.Dec 24 2017, 1:46 AM

eadler removed a reviewer: Src Committers.Dec 24 2017, 6:22 PM

flagged the ones I thought were upstream code...

stand/ficl/ficl.h
152 ↗	(On Diff #36954)	This is actually contrib code that we've lightly edited. I'd prefer you drop this one since it's smack in the middle of a long run of upstream's text.
sys/dev/isp/DriverManual.txt
334 ↗	(On Diff #36954)	upstream?
sys/dev/pms/RefTisa/sat/src/smsat.c
1082 ↗	(On Diff #36954)	This is upstream code...
sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itddisc.c
227 ↗	(On Diff #36954)	ditto...;.
sys/dev/pms/RefTisa/tisa/sassata/sas/tgt/ttdio.c
2177 ↗	(On Diff #36954)	ditto
sys/dev/pms/RefTisa/tisa/sassata/sata/host/sat.c
17645 ↗	(On Diff #36954)	ditto
sys/libkern/zlib.c
704 ↗	(On Diff #36954)	this might be upstream code, but it's going away soon, I think.

Remove code in non-standard locations that are actually third party

The stdlib.h comment looks like it's meant to be "BSD xor C89" rather than "BSD C89". Apart from that it looks good.

Accept with the proviso that the stdlib.h change gets cleared up.

This revision is now accepted and ready to land.Dec 27 2017, 3:17 AM

committed in r327233 r327232 r327231 r327230

Revision Contents
Changeset List

Path

Size

4 lines

bin/

pax/

2 lines

etc/

devd/

24 lines

1 line

rc.initdiskless

2 lines

2 lines

include/

2 lines

lib/

libc/

include/

2 lines

sparc64/

fpu/

2 lines

libedit/

2 lines

2 lines

libefivar/

2 lines

msun/

src/

2 lines

sbin/

devfs/

2 lines

sys/

amd64/

amd64/

2 lines

dev/

ath/

2 lines

bhnd/

nvram/

bhnd_nvram_store_subr.c

2 lines

cadence/

2 lines

de/

2 lines

drm/

4 lines

e1000/

2 lines

isci/

scil/

scic_sds_remote_node_context.c

2 lines

scif_sas_controller.c

2 lines

iwm/

2 lines

mvs/

2 lines

mwl/

2 lines

sfxge/

common/

2 lines

sio/

2 lines

sound/

isa/

2 lines

syscons/

2 lines

fs/

nfsclient/

2 lines

i386/

i386/

2 lines

kern/

2 lines

mips/

conf/

2 lines

net/

altq/

2 lines

2 lines

net80211/

2 lines

ieee80211_scan_sta.c

2 lines

powerpc/

booke/

2 lines

sparc64/

pci/

2 lines

ufs/

ffs/

2 lines

tests/

sys/

fifo/

2 lines

kern/

2 lines

tools/

regression/

bpf/

bpf_filter/

2 lines

usr.bin/

localedef/

2 lines

mail/

2 lines

xargs/

2 lines

usr.sbin/

ctld/

2 lines

makefs/

2 lines

nfsd/

4 lines

rpc.lockd/

2 lines

Diff 36971

UPDATING

Loading...

bin/pax/buf_subs.c

Loading...

etc/devd/hyperv.conf

Loading...

etc/portsnap.conf

Loading...

etc/rc.initdiskless

Loading...

etc/rc.subr

Loading...

include/stdlib.h

Loading...

lib/libc/include/reentrant.h

Loading...

lib/libc/sparc64/fpu/fpu_reg.h

Loading...

lib/libedit/map.c

Loading...

lib/libedit/refresh.c

Loading...

lib/libefivar/uefi-dputil.c

Loading...

lib/msun/src/catrig.c

Loading...

sbin/devfs/rule.c

Loading...

sys/amd64/amd64/support.S

Loading...

sys/dev/ath/if_ath.c

Loading...

sys/dev/bhnd/nvram/bhnd_nvram_store_subr.c

Loading...

sys/dev/cadence/if_cgem.c

Loading...

sys/dev/de/if_de.c

Loading...

sys/dev/drm/mga_state.c

Loading...

sys/dev/e1000/e1000_82543.c

Loading...

sys/dev/isci/scil/scic_sds_remote_node_context.c

Loading...

sys/dev/isci/scil/scif_sas_controller.c

Loading...

sys/dev/iwm/if_iwmreg.h

Loading...

sys/dev/mvs/mvs_pci.c

Loading...

sys/dev/mwl/if_mwl.c

Loading...

sys/dev/sfxge/common/siena_nvram.c

Loading...

sys/dev/sio/sio.c

Loading...

sys/dev/sound/isa/mss.h

Loading...

sys/dev/syscons/scvgarndr.c

Loading...

sys/fs/nfsclient/nfs_clrpcops.c

Loading...

sys/i386/i386/support.s

Loading...

sys/kern/vfs_subr.c

Loading...

sys/mips/conf/BERI_SOCKIT

Loading...

sys/net/altq/altq_hfsc.h

Loading...

sys/net/bpf.c

Loading...

sys/net80211/ieee80211_ht.c

Loading...

sys/net80211/ieee80211_scan_sta.c

Loading...

sys/powerpc/booke/locore.S

Loading...

sys/sparc64/pci/sbbc.c

Loading...

sys/ufs/ffs/ffs_softdep.c

Loading...

tests/sys/fifo/fifo_io.c

Loading...

tests/sys/kern/ptrace_test.c

Loading...

tools/regression/bpf/bpf_filter/bpf_test.c

Loading...

usr.bin/localedef/ctype.c

Loading...

usr.bin/mail/cmd3.c

Loading...

usr.bin/xargs/strnsubst.c

Loading...

usr.sbin/ctld/login.c

Loading...

usr.sbin/makefs/cd9660.c

Loading...

usr.sbin/nfsd/nfsd.c

Loading...

usr.sbin/rpc.lockd/lockd_lock.c

Loading...