I do not plan on committing this all at once, but letting this be a
single review reduces overall spam
Details
Details
- Reviewers
sbruno benno - Group Reviewers
Intel Networking
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 13773 Build 13987: arc lint + arc unit
Event Timeline
Comment Actions
flagged the ones I thought were upstream code...
stand/ficl/ficl.h | ||
---|---|---|
152 ↗ | (On Diff #36954) | This is actually contrib code that we've lightly edited. I'd prefer you drop this one since it's smack in the middle of a long run of upstream's text. |
sys/dev/isp/DriverManual.txt | ||
334 ↗ | (On Diff #36954) | upstream? |
sys/dev/pms/RefTisa/sat/src/smsat.c | ||
1082 ↗ | (On Diff #36954) | This is upstream code... |
sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itddisc.c | ||
227 ↗ | (On Diff #36954) | ditto...;. |
sys/dev/pms/RefTisa/tisa/sassata/sas/tgt/ttdio.c | ||
2177 ↗ | (On Diff #36954) | ditto |
sys/dev/pms/RefTisa/tisa/sassata/sata/host/sat.c | ||
17645 ↗ | (On Diff #36954) | ditto |
sys/libkern/zlib.c | ||
704 ↗ | (On Diff #36954) | this might be upstream code, but it's going away soon, I think. |
Comment Actions
The stdlib.h comment looks like it's meant to be "BSD xor C89" rather than "BSD C89". Apart from that it looks good.