Page MenuHomeFreeBSD

Fix several typos and minor errors
ClosedPublic

Authored by eadler on Dec 24 2017, 1:39 AM.

Details

Reviewers
sbruno
benno
Group Reviewers
Intel Networking
Summary

I do not plan on committing this all at once, but letting this be a
single review reduces overall spam

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 13773
Build 13987: arc lint + arc unit

Event Timeline

eadler created this revision.Dec 24 2017, 1:39 AM
imp added a comment.Dec 24 2017, 7:03 PM

flagged the ones I thought were upstream code...

stand/ficl/ficl.h
152 ↗(On Diff #36954)

This is actually contrib code that we've lightly edited. I'd prefer you drop this one since it's smack in the middle of a long run of upstream's text.

sys/dev/isp/DriverManual.txt
334 ↗(On Diff #36954)

upstream?

sys/dev/pms/RefTisa/sat/src/smsat.c
1082 ↗(On Diff #36954)

This is upstream code...

sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itddisc.c
227 ↗(On Diff #36954)

ditto...;.

sys/dev/pms/RefTisa/tisa/sassata/sas/tgt/ttdio.c
2177 ↗(On Diff #36954)

ditto

sys/dev/pms/RefTisa/tisa/sassata/sata/host/sat.c
17645 ↗(On Diff #36954)

ditto

sys/libkern/zlib.c
704 ↗(On Diff #36954)

this might be upstream code, but it's going away soon, I think.

eadler updated this revision to Diff 36971.Dec 24 2017, 7:19 PM

Remove code in non-standard locations that are actually third party

benno added a subscriber: benno.Dec 27 2017, 3:15 AM

The stdlib.h comment looks like it's meant to be "BSD xor C89" rather than "BSD C89". Apart from that it looks good.

benno accepted this revision.Dec 27 2017, 3:17 AM

Accept with the proviso that the stdlib.h change gets cleared up.

This revision is now accepted and ready to land.Dec 27 2017, 3:17 AM
eadler closed this revision.Dec 27 2017, 3:25 AM

committed in r327233 r327232 r327231 r327230