Exit critical section before calling cpu_spinwait()
AbandonedPublic
Actions

Authored by shurd on Dec 6 2017, 5:32 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Dec 22 2023, 11:06 PM

	Unknown Object (File)
	Nov 30 2023, 4:52 AM

	Unknown Object (File)
	Nov 29 2023, 8:04 AM

	Unknown Object (File)
	Nov 5 2023, 11:14 AM

	Unknown Object (File)
	Nov 1 2023, 11:30 PM

	Unknown Object (File)
	Oct 4 2023, 10:11 AM

	Unknown Object (File)
	Sep 30 2023, 11:27 PM

	Unknown Object (File)
	May 8 2023, 8:36 AM

View All 11 Files

Subscribers

imp

Details

Reviewers

sbruno
kmacy

Summary

We likely shouldn't be waiting in a critical section

Test Plan

Verify assumptions, ensure traffic still passes

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13389
Build 13621: arc lint + arc unit

Event Timeline

shurd created this revision.Dec 6 2017, 5:32 PM

Herald added subscribers: ae, imp. · View Herald TranscriptDec 6 2017, 5:32 PM

Harbormaster completed remote builds in B13389: Diff 36307.Dec 6 2017, 5:32 PM

This is by design. We won't have two rings on the same CPU waiting for each other... we're only waiting for other CPUs to catch up.

Revision Contents
Changeset List

Path

Size

sys/

net/

mp_ring.c

2 lines

Diff 36307

View Options

Exit critical section before calling cpu_spinwait()AbandonedPublicActions