Mk/bsd.port.mk: Setting XDG_DATA_HOME=${STAGEDIR}${PREFIX}/share instead of XDG_DATA_HOME=${WRKDIR} which was wrong
AbandonedPublic

Authored by yuri on Dec 5 2017, 10:06 PM.

Details

Reviewers
mat
tcberner
adamw
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
portmgr
Summary

xdg-utils use XDG_DATA_HOME as a destination of desktop-related files, like .desktop, icons, etc.

See the port here as an example: https://bugs.freebsd.org/bugzilla/attachment.cgi?id=188569&action=diff It has to move icons, etc from WRKDIR.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13363
Build 13595: arc lint + arc unit
yuri created this revision.Dec 5 2017, 10:06 PM
yuri edited the summary of this revision. (Show Details)Dec 5 2017, 10:08 PM
yuri added reviewers: mat, tcberner, adamw.
yuri retitled this revision from Setting XDG_DATA_HOME=${STAGEDIR}${PREFIX}/share instead of XDG_DATA_HOME=${WRKDIR} which was wrong to Mk/bsd.port.mk: Setting XDG_DATA_HOME=${STAGEDIR}${PREFIX}/share instead of XDG_DATA_HOME=${WRKDIR} which was wrong.
yuri edited the summary of this revision. (Show Details)
yuri edited the summary of this revision. (Show Details)Dec 5 2017, 10:14 PM
mat requested changes to this revision.Dec 6 2017, 12:04 PM

Some software use XDG_DATA_HOME to write stuff during the build, so it cannot be pointed to anything else than than the only place where one is allowed to write during the build, which is WRKDIR.

If one port breaks because of this, it is not the framework's fault, please fix that port.

This revision now requires changes to proceed.Dec 6 2017, 12:04 PM
yuri abandoned this revision.Dec 6 2017, 5:43 PM

Ok!