fix shebang sheck with links to non-executable files

[lifanov]

Summary

For normal files, shebang check is ignored if they are not
executable, but for symlinks this is not the case.

This is a prerequisite of an upcoming sysutils/ansible fix.

[antoine]

I believe this will match directories

[lifanov]

address antoine's feedback

Yes, you are correct. Try this please.

[mat]

I wonder why we check shebang of files that are pointed by symbolic links.

[lifanov]

I'm not sure why we check symlinks, but exclusion of executable files pointed to by symlinks doesn't work without this check.

[mat]

In D12497#259099, @mat wrote:

I wonder why we check shebang of files that are pointed by symbolic links.

Ok, so, the history is:

1. check every executable files
2. check only executable files in bin/sbin/libexec/www, but also check symlinks
3. check every executable files, and symlinks

It seems that the second step should have been removed in rP438168 when we went back to all executable files.

I'd vote for removing all the symlink checks.

[lifanov]

Can I commit this fix as-is for now so that I can commit a fix for sysutils/ansible please?

[antoine]

In D12497#259099, @mat wrote:

I wonder why we check shebang of files that are pointed by symbolic links.

It was for the case of /usr/local/bin/foo ->/usr/local/obscuredirectory/foo

But now that we check more than files/links in $PATH , it may no longer be needed

[lifanov]

The above check would have caught /usr/local/obscuredirectory/foo without a symlink to it.

$(find ${STAGEDIR}${PREFIX} \
    -type f -perm +111 2>/dev/null)

[mat]

Yes, I removed the obsolete symlinks thing in rP450638.

[lifanov]

Woo, thank you mat!