ixl: Fix mbuf hash type settings.
ClosedPublic
Actions

Authored by sepherosa_gmail.com on Sep 22 2017, 3:49 AM.

Details

Reviewers

sbruno
adrian
rwatson
gallatin
erj

Group Reviewers

Intel Networking

Commits

rS324051: ixl: Fix mbuf hash type settings.

Summary

IPV6_EXs in RSS never mean fragment.  They mean:
"- Home address from the home address option in the IPv6 destination
   options header.  If the extension header is not present, use the
   Source IPv6 Address.
 - IPv6 address that is contained in the Routing-Header-Type-2 from
   the associated extension header.  If the extension header is not
   present, use the Destination IPv6 Address."

UDP_IPV4_EX is an invalid RSS hash type, which will be removed.

Quoted from:
https://docs.microsoft.com/en-us/windows-hardware/drivers/network/rss-hashing-types#ndishashipv6ex

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

sepherosa_gmail.com created this revision.Sep 22 2017, 3:49 AM

Herald added a subscriber: ae. · View Herald TranscriptSep 22 2017, 3:49 AM

Did microsoft update the referenced link? I don't see the removal notice in it.

In D12450#258277, @sbruno wrote:

Did microsoft update the referenced link? I don't see the removal notice in it.

The UDP_IPV4_EX was never defined. FreeBSD defined it by mistake.

erj accepted this revision.Sep 23 2017, 6:13 PM

This revision is now accepted and ready to land.Sep 23 2017, 6:13 PM

Closed by commit rS324051: ixl: Fix mbuf hash type settings. (authored by sephe). · Explain WhySep 27 2017, 6:00 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ixl/

ixl_txrx.c

38 lines

Diff 33297

View Options

ixl: Fix mbuf hash type settings.ClosedPublicActions