- upstream requires golang >= 1.9
Details
- Reviewers
swills jrm - Commits
- rP449937: security/vault: update 7.2 -> 8.2
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
I'd like to include the rc.d changes proposed in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=215896 however this would require checking for OSVERSION > 1101000 to be sure that daemon(8) has the necessary flags to support stdio redirection, as these were only added in 11.1. Is it appropriate to use ports compiletime checking of OSVERSION in the Makefile to toggle support for the additional flags, or should this be a runtime check in the rc.d script itself? Suggestions welcome for the latter.
security/vault/Makefile | ||
---|---|---|
19 ↗ | (On Diff #33041) | Is defining COMMIT_ID necessary when there is a tagged release? It builds fine for me without this. |
Maybe something like '4.4.4. Patching Conditionally' in the Porter's Handbook provides what you are looking for.
Did you run this through portlint -C and poudriere for 10/11 i386/amd64?
security/vault/Makefile | ||
---|---|---|
4–5 ↗ | (On Diff #33041) | The Porter's Handbook now recommends DISTVERSION, which usually does the right thing wrt setting PORTVERSION. DISTVERSIONPREFIX= v DISTVERSION= 0.8.2 |
security/vault/Makefile | ||
---|---|---|
19 ↗ | (On Diff #33041) | Yes, it is: @${REINPLACE_CMD} -e 's|%%COMMIT_ID%%|${COMMIT_ID}|g' ${WRKSRC}/version/version.go |
security/vault/Makefile | ||
---|---|---|
19 ↗ | (On Diff #33041) | Oh sheesh. I missed that and it was just below. :-/ |
FWIW this passes portlint, and my poudriere matrix
11.1R amd64 + i386, 10.3R amd64 + i386. I'll commit
this and then look at the PR rc.d script separately: