Fix b64_pton output buffer overrun test for exact-sized buffer
ClosedPublic
Actions

Authored by emaste on Nov 24 2014, 4:51 PM.

Details

Reviewers

trasz
loos

Commits

rS275060: Fix b64_pton output buffer overrun test for exact-sized buffer

Summary

Submitted by: Ted Unangst
Obtained from: OpenBSD

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste updated this revision to Diff 2527.Nov 24 2014, 4:51 PM

emaste retitled this revision from to Fix b64_pton output buffer overrun test for exact-sized buffer.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added a reviewer: trasz.

For posterity, Ted's note to freebsd-hackers@:

From inspection, it appears FreeBSD's libc base64.c will sometimes erroneously fail to decode a base64 string into a precisely sized buffer. The overflow check is a little too greedy. The same bug was fixed in OpenBSD; it would be helpful if FreeBSD adopted the fix as well. :)

http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/lib/libc/net/base64.c.diff?r1=1.6&r2=1.7

I can easily reproduce the problem and the patch does fix it.

Please, go ahead.

This revision is now accepted and ready to land.Nov 25 2014, 1:32 PM

I don't see anything wrong with the patch, but my understanding of this code is rather poor.

trasz accepted this revision.Nov 25 2014, 4:46 PM

trasz edited edge metadata.

Closed by commit rS275060 (authored by @emaste).

Revision Contents
Changeset List

Path

Size

head/

lib/

libc/

net/

base64.c

22 lines

Diff 2546

View Options

head/lib/libc/net/base64.c

Fix b64_pton output buffer overrun test for exact-sized bufferClosedPublicActions