- Indent <screen> content properly
- Add missing quote in 'zfs set sharenfs' command
- Use root prompt in various places to reflect reality
- Add missing <userinput> tags
- Remove a useless 'zfs list' command
Details
Details
Diff Detail
Diff Detail
- Repository
- rD FreeBSD doc repository - subversion
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 32240 Build 29730: arc lint + arc unit
Event Timeline
Comment Actions
A few things I've found.
| zfs/chapter.xml | ||
|---|---|---|
| 1896 ↗ | (On Diff #32404) | Be careful not to mix whitespace with content changes. These need to be two separate commits: one for the indentations and the rest for the content changes you listed. |
| 2179 ↗ | (On Diff #32404) | I think this example should also contain vi.recover. Otherwise, readers might wonder where it is coming from all of a sudden after the rollback or whether it was caused by the rollback (which is not, but that might cause confusion). |
| 2650 ↗ | (On Diff #32404) | While we're here, we could replace this line with sysrc: |
| zfs/chapter.xml | ||
|---|---|---|
| 1896 ↗ | (On Diff #32404) | Whitespace inside <screen> and <programlisting> elements really is content. That is, it affects how the final rendered version appears, where normal whitespace like that in paragraphs does not. And the point of this whole whitespace runaround is to make sure translators only see changes to content that affects how the final rendered version looks. |
| head/en_US.ISO8859-1/books/handbook/zfs/chapter.xml | ||
|---|---|---|
| 2652 ↗ | (On Diff #32448) | sysrc cannot be used for sysctls: $ sudo sysrc -f /etc/sysctl.conf vfs.usermount=1 as pointed out here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246760 |
Comment Actions
At the request of @allanjude, I'm commandeering this to make a little change so that sysrc doesn't try to operate on files it can't work on.